github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1423] [MERGED] Use 2 iterations for local password hashing #2880

New Issue
Closed
opened 2025-11-26 23:25:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1423
Author: @eliykat
Created: 6/10/2021
Status: ✅ Merged
Merged: 6/14/2021
Merged by: @eliykat

Base: master ← Head: hashpurpose

📝 Commits (5)

  • aff8227 Add HashPurpose parameter to HashPasswordAsync
  • 35aebaa Use 2 iterations for local password hashing
  • 497d492 Force logout if user has old keyHash stored
  • dcffcf2 Revert "Force logout if user has old keyHash stored"
  • 1ed1e58 Add backwards compatability with existing keyHash

📊 Changes

9 files changed (+76 additions, -48 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+19 -20)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+3 -2)
📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+2 -3)
📝 src/App/Services/MobilePasswordRepromptService.cs (+1 -9)
📝 src/Core/Abstractions/ICryptoService.cs (+2 -1)
➕ src/Core/Enums/HashPurpose.cs (+8 -0)
📝 src/Core/Services/AuthService.cs (+11 -7)
📝 src/Core/Services/CryptoService.cs (+25 -2)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+5 -4)

📄 Description

Objective

Implement https://github.com/bitwarden/jslib/pull/404 and https://github.com/bitwarden/jslib/pull/407 for mobile.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1423 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 6/10/2021 **Status:** ✅ Merged **Merged:** 6/14/2021 **Merged by:** [@eliykat](https://github.com/eliykat) **Base:** `master` ← **Head:** `hashpurpose` --- ### 📝 Commits (5) - [`aff8227`](https://github.com/bitwarden/android/commit/aff8227989106485c1c28972269499a4099bf1e2) Add HashPurpose parameter to HashPasswordAsync - [`35aebaa`](https://github.com/bitwarden/android/commit/35aebaa3e02e5777866ddef240efc44e9ec9daaf) Use 2 iterations for local password hashing - [`497d492`](https://github.com/bitwarden/android/commit/497d4928fa7e1f2814b455d90a7a788e15d8ec98) Force logout if user has old keyHash stored - [`dcffcf2`](https://github.com/bitwarden/android/commit/dcffcf2dba780af2ab1624e2abd38e0e6347bfa1) Revert "Force logout if user has old keyHash stored" - [`1ed1e58`](https://github.com/bitwarden/android/commit/1ed1e58d371e536c8682a6dfe6f609d856d85dcd) Add backwards compatability with existing keyHash ### 📊 Changes **9 files changed** (+76 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+19 -20) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+3 -2) 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+2 -3) 📝 `src/App/Services/MobilePasswordRepromptService.cs` (+1 -9) 📝 `src/Core/Abstractions/ICryptoService.cs` (+2 -1) ➕ `src/Core/Enums/HashPurpose.cs` (+8 -0) 📝 `src/Core/Services/AuthService.cs` (+11 -7) 📝 `src/Core/Services/CryptoService.cs` (+25 -2) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+5 -4) </details> ### 📄 Description ## Objective Implement https://github.com/bitwarden/jslib/pull/404 and https://github.com/bitwarden/jslib/pull/407 for mobile. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2880
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?