github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1421] [MERGED] Track failed unlock attempts in storage #2878

New Issue
Closed
opened 2025-11-26 23:25:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1421
Author: @mpbw2
Created: 6/9/2021
Status: ✅ Merged
Merged: 6/9/2021
Merged by: @mpbw2

Base: master ← Head: failed-unlock-tracking

📝 Commits (1)

  • 2db704c track failed unlock attempts in storage

📊 Changes

7 files changed (+82 additions, -7 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+12 -3)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+2 -0)
📝 src/App/Pages/Accounts/LoginSsoPageViewModel.cs (+2 -0)
📝 src/App/Services/MobileStorageService.cs (+1 -0)
📝 src/App/Utilities/AppHelpers.cs (+15 -0)
📝 src/Core/Constants.cs (+1 -0)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+49 -4)

📄 Description

Track failed unlock attempts in device storage instead of memory to prevent brute-force attacks for PIN or master password on unlock screen. (HackerOne report # 1217914)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1421 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/9/2021 **Status:** ✅ Merged **Merged:** 6/9/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `failed-unlock-tracking` --- ### 📝 Commits (1) - [`2db704c`](https://github.com/bitwarden/android/commit/2db704c18c80a5150f95e0540e34683c25c3faa5) track failed unlock attempts in storage ### 📊 Changes **7 files changed** (+82 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+12 -3) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+2 -0) 📝 `src/App/Pages/Accounts/LoginSsoPageViewModel.cs` (+2 -0) 📝 `src/App/Services/MobileStorageService.cs` (+1 -0) 📝 `src/App/Utilities/AppHelpers.cs` (+15 -0) 📝 `src/Core/Constants.cs` (+1 -0) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+49 -4) </details> ### 📄 Description Track failed unlock attempts in device storage instead of memory to prevent brute-force attacks for PIN or master password on unlock screen. (HackerOne report # 1217914) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2878
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?