github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1412] [MERGED] Add encKeyValidation string to encrypted exports #2874

New Issue
Closed
opened 2025-11-26 23:25:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1412
Author: @eliykat
Created: 5/28/2021
Status: ✅ Merged
Merged: 5/28/2021
Merged by: @eliykat

Base: master ← Head: export-encKeyValidation

📝 Commits (1)

  • 05c2a88 Add encKeyValidation string to encrypted exports

📊 Changes

2 files changed (+10 additions, -4 deletions)

View changed files

📝 src/Core/Services/ExportService.cs (+9 -3)
📝 src/Core/Utilities/ServiceContainer.cs (+1 -1)

📄 Description

Objective

In https://github.com/bitwarden/jslib/pull/369, I added an arbitrary encString at the top of encrypted exports. When the data is imported, this encString is decrypted first as a check to make sure that the encKey has not changed.

This PR replicates the change for mobile, by adding the encString to the top of encrypted exports.

Not implemented:

  • dealing with organizations, as it looks like organization exports are not implemented in mobile
  • importing data, as this can only be done via the web vault.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1412 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 5/28/2021 **Status:** ✅ Merged **Merged:** 5/28/2021 **Merged by:** [@eliykat](https://github.com/eliykat) **Base:** `master` ← **Head:** `export-encKeyValidation` --- ### 📝 Commits (1) - [`05c2a88`](https://github.com/bitwarden/android/commit/05c2a88af52d4c15984fd785ee5e7172cac40d1f) Add encKeyValidation string to encrypted exports ### 📊 Changes **2 files changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/ExportService.cs` (+9 -3) 📝 `src/Core/Utilities/ServiceContainer.cs` (+1 -1) </details> ### 📄 Description ## Objective In https://github.com/bitwarden/jslib/pull/369, I added an arbitrary `encString` at the top of encrypted exports. When the data is imported, this `encString` is decrypted first as a check to make sure that the encKey has not changed. This PR replicates the change for mobile, by adding the `encString` to the top of encrypted exports. Not implemented: * dealing with organizations, as it looks like organization exports are not implemented in mobile * importing data, as this can only be done via the web vault. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2874
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?