github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1410] [MERGED] replaced blank taskaffinity with singletask launchmode #2872

New Issue
Closed
opened 2025-11-26 23:25:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1410
Author: @mpbw2
Created: 5/25/2021
Status: ✅ Merged
Merged: 5/26/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-taskstack

📝 Commits (1)

  • 7e7256e replaced blank taskaffinity with singletask launchmode

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 src/Android/MainActivity.cs (+1 -1)
📝 src/Android/WebAuthCallbackActivity.cs (+0 -1)

📄 Description

These changes broke the SSO auth flow (Xamarin.Essentials.WebAuthenticatorCallbackActivity can't deliver a callback to an activity with a different TaskAffinity). Using SingleTask launch mode in our main activity still fixes the issue reported to us while maintaining TaskAffinity with other activities. In addition WebAuthCallbackActivity must remain exported for this to work.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1410 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 5/25/2021 **Status:** ✅ Merged **Merged:** 5/26/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-taskstack` --- ### 📝 Commits (1) - [`7e7256e`](https://github.com/bitwarden/android/commit/7e7256e7cd11e16f2ffedab61a7a25573ee0d86a) replaced blank taskaffinity with singletask launchmode ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+1 -1) 📝 `src/Android/WebAuthCallbackActivity.cs` (+0 -1) </details> ### 📄 Description [These changes](https://github.com/bitwarden/mobile/commit/e61bcd278548b7d8bb3925d8dc89f616c17b1c7d) broke the SSO auth flow (`Xamarin.Essentials.WebAuthenticatorCallbackActivity` can't deliver a callback to an activity with a different TaskAffinity). Using `SingleTask` launch mode in our main activity still fixes the issue reported to us while maintaining TaskAffinity with other activities. In addition `WebAuthCallbackActivity` must remain exported for this to work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?