github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1408] [MERGED] fix for activity exporting and workaround for task affinity #2871

New Issue
Closed
opened 2025-11-26 23:25:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1408
Author: @mpbw2
Created: 5/19/2021
Status: ✅ Merged
Merged: 5/19/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-activityexport

📝 Commits (1)

  • eedfbac fix for activity exporting and workaround for task affinity

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 src/Android/MainActivity.cs (+1 -0)
📝 src/Android/WebAuthCallbackActivity.cs (+4 -1)

📄 Description

  • Android: make sure WebAuthCallbackActivity isn't exported
  • Android: make TaskAffinity for MainActivity empty to address strandhogg v1 & v2 vulnerability

Things to consider:

These changes have the potential to affect established app behavior, and as such will require regression with a focus on autofill, accessibility, and the SSO authentication flow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1408 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 5/19/2021 **Status:** ✅ Merged **Merged:** 5/19/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-activityexport` --- ### 📝 Commits (1) - [`eedfbac`](https://github.com/bitwarden/android/commit/eedfbaca0c2a9c09d6ec3e8a044987514b1d8167) fix for activity exporting and workaround for task affinity ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+1 -0) 📝 `src/Android/WebAuthCallbackActivity.cs` (+4 -1) </details> ### 📄 Description - Android: make sure `WebAuthCallbackActivity` isn't exported - Android: make TaskAffinity for `MainActivity` empty to address strandhogg v1 & v2 vulnerability **Things to consider:** These changes have the potential to affect established app behavior, and as such will require regression with a focus on autofill, accessibility, and the SSO authentication flow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2871
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?