github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 09:06:13 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #888] [MERGED] Usability improvements to accessibility settings #28653

New Issue
Closed
opened 2026-04-18 12:47:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 12:47:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/888
Author: @mpbw2
Created: 5/7/2020
Status: ✅ Merged
Merged: 5/7/2020
Merged by: @mpbw2

Base: master ← Head: hide-enabled-accbuttons

📝 Commits (1)

  • 7b829e0 Usability improvements to accessibility settings

📊 Changes

1 file changed (+23 additions, -31 deletions)

View changed files

📝 src/App/Pages/Settings/AccessibilityServicePage.xaml (+23 -31)

📄 Description

Adjusted layout and logic of accessibility settings to better match the cleaner autofill service settings. Screenshots from Nexus 5X to demonstrate with space restrictions:


Screen 1: Both accessibility and the draw-over permission are disabled:


01-all_off


Screen 2: Accessibility is enabled but the draw-over permission isn't:


02-acc_on_drawover_off


Screen 3: Accessibility isn't enabled but the draw-over permission is (this is what most users will see if/when we're granted automatic draw-over permission from the play store):


03-acc_off_drawover_on


Screen 4: Both accessibility and draw-over permission are enabled:


04-all_on

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/888 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 5/7/2020 **Status:** ✅ Merged **Merged:** 5/7/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `hide-enabled-accbuttons` --- ### 📝 Commits (1) - [`7b829e0`](https://github.com/bitwarden/android/commit/7b829e03acee76daadced11fedf853a3024b9c0a) Usability improvements to accessibility settings ### 📊 Changes **1 file changed** (+23 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/AccessibilityServicePage.xaml` (+23 -31) </details> ### 📄 Description Adjusted layout and logic of accessibility settings to better match the cleaner autofill service settings. Screenshots from Nexus 5X to demonstrate with space restrictions: <br> ### Screen 1: Both accessibility and the draw-over permission are disabled: <br> ![01-all_off](https://user-images.githubusercontent.com/59324545/81340745-5ab03d80-907e-11ea-8ab4-79f2da5a81d3.png) <br> ### Screen 2: Accessibility is enabled but the draw-over permission isn't: <br> ![02-acc_on_drawover_off](https://user-images.githubusercontent.com/59324545/81340793-7287c180-907e-11ea-88c0-758ec1bbe9b0.png) <br> ### Screen 3: Accessibility isn't enabled but the draw-over permission is (this is what most users will see if/when we're granted automatic draw-over permission from the play store): <br> ![03-acc_off_drawover_on](https://user-images.githubusercontent.com/59324545/81340934-a8c54100-907e-11ea-8897-c5f4eb4d7d35.png) <br> ### Screen 4: Both accessibility and draw-over permission are enabled: <br> ![04-all_on](https://user-images.githubusercontent.com/59324545/81340957-bf6b9800-907e-11ea-8d23-997b0fe7739f.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 12:47:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#28653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?