github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1395] [MERGED] Explain how to verify email for file Sends #2865

New Issue
Closed
opened 2025-11-26 23:25:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1395
Author: @eliykat
Created: 5/11/2021
Status: ✅ Merged
Merged: 5/11/2021
Merged by: @mpbw2

Base: master ← Head: improve-verify-email-message

📝 Commits (3)

  • b72314b Explain how to verify email for file Sends
  • b659abd Revert "Explain how to verify email for file Sends"
  • b9cd1d0 Explain how to verify email for file Sends

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+0 -1)
📝 src/App/Resources/AppResources.resx (+1 -1)

📄 Description

Objective

Users are required to verify their email before creating a file Send, however the current message doesn't provide any explanation about how to do this. This is especially a problem because you can't verify your email in the mobile app, so it's not obvious that you have to go somewhere else to do it.

Code changes

I've used the same UX flow as settings that can only be changed in the web vault:

  • explain to the user that this can only be done on the "bitwarden.com web vault" (may be inaccurate for self hosted, but I've stuck to the current pattern)
  • offer to take the user there now, which takes the user to the relevant help documentation

I'll replicate these changes for desktop and browser tomorrow.

Bonus: deleted unused private var I left there from the 'hide email' feature.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1395 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 5/11/2021 **Status:** ✅ Merged **Merged:** 5/11/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `improve-verify-email-message` --- ### 📝 Commits (3) - [`b72314b`](https://github.com/bitwarden/android/commit/b72314bc935b8445293c0d780b13319516b057fb) Explain how to verify email for file Sends - [`b659abd`](https://github.com/bitwarden/android/commit/b659abddbe62a76bb9c26a5402b5d6ec251d24fe) Revert "Explain how to verify email for file Sends" - [`b9cd1d0`](https://github.com/bitwarden/android/commit/b9cd1d076624634129e6c4415a59ae8bf496cbb6) Explain how to verify email for file Sends ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+0 -1) 📝 `src/App/Resources/AppResources.resx` (+1 -1) </details> ### 📄 Description ## Objective Users are required to verify their email before creating a file Send, however the current message doesn't provide any explanation about how to do this. This is especially a problem because you can't verify your email in the mobile app, so it's not obvious that you have to go somewhere else to do it. ## Code changes I've used the same UX flow as settings that can only be changed in the web vault: * explain to the user that this can only be done on the "bitwarden.com web vault" (may be inaccurate for self hosted, but I've stuck to the current pattern) * offer to take the user there now, which takes the user to the relevant help documentation I'll replicate these changes for desktop and browser tomorrow. Bonus: deleted unused private var I left there from the 'hide email' feature. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2865
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?