github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1385] [MERGED] Limit file upload sizes to 100MB #2863

New Issue
Closed
opened 2025-11-26 23:25:11 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:11 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1385
Author: @MGibson1
Created: 4/27/2021
Status: ✅ Merged
Merged: 4/27/2021
Merged by: @MGibson1

Base: master ← Head: revert-max-attachment-and-send-size

📝 Commits (1)

  • b15c440 Limit file upload sizes to 100MB

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+1 -1)
📝 src/App/Pages/Vault/AttachmentsPageViewModel.cs (+1 -1)
📝 src/App/Resources/AppResources.resx (+1 -1)

📄 Description

Overview

Both iOS and Android are having trouble with the current method of loading the entire file to memory, encrypting it, and sending to azure in one go.

We will need to come up with a chunking scheme to support larger files in the future

Files Changed

  • SendAddEditPageViewModel: Validate file is not longer that 100MB
  • AttachmentsPageViewModel: Validate file is not longer than 100MB
  • AppResources: Revert size limit text to 100 MB

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1385 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 4/27/2021 **Status:** ✅ Merged **Merged:** 4/27/2021 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `revert-max-attachment-and-send-size` --- ### 📝 Commits (1) - [`b15c440`](https://github.com/bitwarden/android/commit/b15c4405e2751a00f47ee909389de8e640641702) Limit file upload sizes to 100MB ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+1 -1) 📝 `src/App/Pages/Vault/AttachmentsPageViewModel.cs` (+1 -1) 📝 `src/App/Resources/AppResources.resx` (+1 -1) </details> ### 📄 Description # Overview Both iOS and Android are having trouble with the current method of loading the entire file to memory, encrypting it, and sending to azure in one go. We will need to come up with a chunking scheme to support larger files in the future # Files Changed * **SendAddEditPageViewModel**: Validate file is not longer that 100MB * **AttachmentsPageViewModel**: Validate file is not longer than 100MB * **AppResources**: Revert size limit text to 100 MB --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:11 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2863
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?