github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-25 07:41:55 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1384] [MERGED] Expand package visibility for Android 11+ #2862

New Issue
Closed
opened 2025-11-26 23:25:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:25:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1384
Author: @mpbw2
Created: 4/27/2021
Status: ✅ Merged
Merged: 5/13/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-packagevis-android11

📝 Commits (1)

  • ab99224 expand package visibility for Android 11+

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 src/Android/Properties/AndroidManifest.xml (+1 -6)

📄 Description

The previous fix to open URIs in Android 11+ did not take into account app (i.e. non-web) URIs. In order for PackageManager.GetLaunchIntentForPackage(..) to function in Android 11+, the package has to be visible to us. Visibility can be specified by exact package name or types of actions with filters. Since neither is practical when the user can specify any and all current and future apps, we've gone the wildcard route with the name and removed the optional scheme. This gives us enough app visibility to build launch intents using known package names without requiring the QUERY_ALL_PACKAGES permission.

Additional reading: https://developer.android.com/training/package-visibility

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1384 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/27/2021 **Status:** ✅ Merged **Merged:** 5/13/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-packagevis-android11` --- ### 📝 Commits (1) - [`ab99224`](https://github.com/bitwarden/android/commit/ab992246b108c888210e81b33784a0ec3dc964a3) expand package visibility for Android 11+ ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Properties/AndroidManifest.xml` (+1 -6) </details> ### 📄 Description The previous fix to open URIs in Android 11+ did not take into account app (i.e. non-web) URIs. In order for `PackageManager.GetLaunchIntentForPackage(..)` to function in Android 11+, the package has to be visible to us. Visibility can be specified by exact package name or types of actions with filters. Since neither is practical when the user can specify any and all current and future apps, we've gone the wildcard route with the `name` and removed the optional `scheme`. This gives us enough app visibility to build launch intents using known package names without requiring the `QUERY_ALL_PACKAGES` permission. Additional reading: https://developer.android.com/training/package-visibility --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2862
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?