github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #827] [MERGED] [Autofill] Apply locked autofill flow to logged out state #28610

New Issue
Closed
opened 2026-04-18 12:45:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 12:45:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/827
Author: @vincentsalucci
Created: 4/10/2020
Status: ✅ Merged
Merged: 4/13/2020
Merged by: @vincentsalucci

Base: master ← Head: auto-fill-logged-out

📝 Commits (9)

  • 6f1e99c Initial commit: apply locked auto-fill flow to log out auto-fill
  • 6247661 Alphabetized imports
  • 3ec41f0 Removed unnecessary else conditional
  • b2abcda Fix for talkback slider control (#828)
  • d6228b1 Initial commit: apply locked auto-fill flow to log out auto-fill
  • 18023e7 Alphabetized imports
  • 1dbf536 Removed unnecessary else conditional
  • e681654 Merge branch 'auto-fill-logged-out' of github.com:bitwarden/mobile into auto-fill-logged-out
  • ad9989b Fixed variable init order

📊 Changes

9 files changed (+90 additions, -14 deletions)

View changed files

📝 src/App/App.csproj (+1 -1)
📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Pages/Accounts/HomePage.xaml.cs (+7 -4)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+1 -1)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+40 -2)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+5 -3)
📝 src/App/Pages/Accounts/TwoFactorPage.xaml.cs (+31 -1)
📝 src/App/Pages/Accounts/TwoFactorPageViewModel.cs (+3 -1)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+1 -0)

📄 Description

Objective

Allow logged out applications to be aware of auto-fill flow. This closes a gap between being locked vs logged out from timeout/restart.

Code Changes

  • App.xaml.cs: Passed appOptions into HomePage constructor
  • HomePage.xaml.cs: Updated constructor to accept appOptions. Passed appOptions into LoginPage
  • LoginPage.xaml.cs: Updated constructor to accept appOptions. Passed appOptions into TwoFactorPage and added two helpers for moving to next page.
  • LoginPageViewModel.cs: Added StartTwoFactorAction and LoggedInAction properties and invoked during page change.
  • TwoFactorPage.xaml.cs: Updated constructor to accept appOptions and init storageService. Added helper for moving to next page.
  • TwoFactorPageViewModel.cs: Added TwoFactorAction property and invoked during page change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/827 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 4/10/2020 **Status:** ✅ Merged **Merged:** 4/13/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `auto-fill-logged-out` --- ### 📝 Commits (9) - [`6f1e99c`](https://github.com/bitwarden/android/commit/6f1e99cd1309a9021aed2b7e5f43c9f3b5db5537) Initial commit: apply locked auto-fill flow to log out auto-fill - [`6247661`](https://github.com/bitwarden/android/commit/62476615aebf391316b34f442b978188d198285d) Alphabetized imports - [`3ec41f0`](https://github.com/bitwarden/android/commit/3ec41f0baa8eae3c248dea55b2625ec1dc19b2c3) Removed unnecessary else conditional - [`b2abcda`](https://github.com/bitwarden/android/commit/b2abcda1117044ce6b7a30fc652bb3781b924ee9) Fix for talkback slider control (#828) - [`d6228b1`](https://github.com/bitwarden/android/commit/d6228b16e5bef92d574c529bf598aabacd7b72ea) Initial commit: apply locked auto-fill flow to log out auto-fill - [`18023e7`](https://github.com/bitwarden/android/commit/18023e741193d9eb7a60ee292df5190a4b74d29a) Alphabetized imports - [`1dbf536`](https://github.com/bitwarden/android/commit/1dbf5363cf954271531ba4c07400fc83ab2a05e4) Removed unnecessary else conditional - [`e681654`](https://github.com/bitwarden/android/commit/e68165458a4878607196e00ac768c2bca6a037df) Merge branch 'auto-fill-logged-out' of github.com:bitwarden/mobile into auto-fill-logged-out - [`ad9989b`](https://github.com/bitwarden/android/commit/ad9989bf8d4845611b27cf44dd2d4bd4c80017ea) Fixed variable init order ### 📊 Changes **9 files changed** (+90 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+1 -1) 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+7 -4) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+40 -2) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+5 -3) 📝 `src/App/Pages/Accounts/TwoFactorPage.xaml.cs` (+31 -1) 📝 `src/App/Pages/Accounts/TwoFactorPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+1 -0) </details> ### 📄 Description ## Objective > Allow logged out applications to be aware of auto-fill flow. This closes a gap between being locked vs logged out from timeout/restart. ## Code Changes - **App.xaml.cs**: Passed `appOptions` into `HomePage` constructor - **HomePage.xaml.cs**: Updated constructor to accept `appOptions`. Passed `appOptions` into `LoginPage` - **LoginPage.xaml.cs**: Updated constructor to accept `appOptions`. Passed `appOptions` into `TwoFactorPage` and added two helpers for moving to next page. - **LoginPageViewModel.cs**: Added `StartTwoFactorAction` and `LoggedInAction` properties and invoked during page change. - **TwoFactorPage.xaml.cs**: Updated constructor to accept `appOptions` and init `storageService`. Added helper for moving to next page. - **TwoFactorPageViewModel.cs**: Added `TwoFactorAction` property and invoked during page change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 12:45:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#28610
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?