[PR #1383] [MERGED] update firebase messaging lib and implementation #2861

Closed
opened 2025-11-26 23:25:09 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1383
Author: @mpbw2
Created: 4/26/2021
Status: Merged
Merged: 5/3/2021
Merged by: @mpbw2

Base: masterHead: update-firebase-msg


📝 Commits (2)

  • 68b1b69 update firebase messaging lib and implementation
  • ef7ef4c update clean-fdroid script for updated firebase

📊 Changes

5 files changed (+17 additions, -53 deletions)

View changed files

📝 .github/scripts/android/clean-fdroid.ps1 (+4 -10)
📝 src/Android/Android.csproj (+2 -2)
📝 src/Android/Properties/AndroidManifest.xml (+0 -14)
src/Android/Push/FirebaseInstanceIdService.cs (+0 -25)
📝 src/Android/Push/FirebaseMessagingService.cs (+11 -2)

📄 Description

Brings firebase messaging up to date

  • AndroidManifest.xml: Removed FirebaseInstance* receivers (handled by updated lib)
  • FirebaseInstanceIdService.cs: DELETED - no longer required for updated lib
  • FirebaseMessagingService.cs: Set Exported=false and added/moved OnNewToken(..) method/logic from deprecated FirebaseInstanceIdService
  • Android.csproj: Updated Xamarin.Firebase.Messaging to 121.0.1, added latest Xamarin.Google.Dagger (required by updated Firebase lib), and removed FirebaseInstanceIdService.cs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1383 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 4/26/2021 **Status:** ✅ Merged **Merged:** 5/3/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `update-firebase-msg` --- ### 📝 Commits (2) - [`68b1b69`](https://github.com/bitwarden/android/commit/68b1b69518efad0bdf31d14eeea3a45effd5d05c) update firebase messaging lib and implementation - [`ef7ef4c`](https://github.com/bitwarden/android/commit/ef7ef4cd13329d9fdff223ea64dba8e8ed0cad0a) update clean-fdroid script for updated firebase ### 📊 Changes **5 files changed** (+17 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `.github/scripts/android/clean-fdroid.ps1` (+4 -10) 📝 `src/Android/Android.csproj` (+2 -2) 📝 `src/Android/Properties/AndroidManifest.xml` (+0 -14) ➖ `src/Android/Push/FirebaseInstanceIdService.cs` (+0 -25) 📝 `src/Android/Push/FirebaseMessagingService.cs` (+11 -2) </details> ### 📄 Description Brings firebase messaging up to date - **AndroidManifest.xml:** Removed `FirebaseInstance*` receivers (handled by updated lib) - **FirebaseInstanceIdService.cs:** DELETED - no longer required for updated lib - **FirebaseMessagingService.cs:** Set `Exported=false` and added/moved `OnNewToken(..)` method/logic from deprecated `FirebaseInstanceIdService` - **Android.csproj:** Updated `Xamarin.Firebase.Messaging` to `121.0.1`, added latest `Xamarin.Google.Dagger` (required by updated Firebase lib), and removed `FirebaseInstanceIdService.cs` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:09 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2861