github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #761] [MERGED] Fixed issue where multiple threads were attempting to modify search result list #28586

New Issue
Closed
opened 2026-04-18 12:44:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 12:44:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/761
Author: @mpbw2
Created: 3/9/2020
Status: ✅ Merged
Merged: 3/9/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-observablecollectionsmodfromtask

📝 Commits (2)

  • c9583a1 Fixed issue where multiple threads were attempting to modify search result list
  • 3cc7b73 Fixed race condition

📊 Changes

2 files changed (+9 additions, -6 deletions)

View changed files

📝 src/App/Pages/Vault/CiphersPage.xaml.cs (+1 -1)
📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+8 -5)

📄 Description

  • Perform search result list update on main thread to force thread safety on the underlying ObservableCollection. This fixes the occasional ArgumentOutOfRangeException as well as the strange behavior where hitting the IME "enter" key after entering text would clear the results and state none were found even though they exist.

  • Changed existing search execution delay for keystrokes to 200ms to match web

  • Fixed race condition where non-delayed search (keyboard "enter") jumped the queue and the prior delayed search (text change) would still modify the search results, contributing to the "no results found" problem (we're now returning when OperationCanceledException is thrown)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/761 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/9/2020 **Status:** ✅ Merged **Merged:** 3/9/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-observablecollectionsmodfromtask` --- ### 📝 Commits (2) - [`c9583a1`](https://github.com/bitwarden/android/commit/c9583a1b3333351e9bc9712ab9c496c4ebf2199d) Fixed issue where multiple threads were attempting to modify search result list - [`3cc7b73`](https://github.com/bitwarden/android/commit/3cc7b7390578983d0f808c424b9437990f63fb9f) Fixed race condition ### 📊 Changes **2 files changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CiphersPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+8 -5) </details> ### 📄 Description - Perform search result list update on main thread to force thread safety on the underlying ObservableCollection. This fixes the occasional `ArgumentOutOfRangeException` as well as the strange behavior where hitting the IME "enter" key after entering text would clear the results and state none were found even though they exist. - Changed existing search execution delay for keystrokes to 200ms to match web - Fixed race condition where non-delayed search (keyboard "enter") jumped the queue and the prior delayed search (text change) would still modify the search results, contributing to the "no results found" problem (we're now returning when `OperationCanceledException` is thrown) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 12:44:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#28586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?