github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1366] [MERGED] Use CipherByteArray to signify encrypted byte[] #2852

New Issue
Closed
opened 2025-11-26 23:24:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1366
Author: @MGibson1
Created: 4/14/2021
Status: ✅ Merged
Merged: 4/21/2021
Merged by: @MGibson1

Base: master ← Head: encrypt-to-encrypted-array-type

📝 Commits (2)

  • b8b2acb Use CipherByteArray to signify encrypted byte[]
  • 3afd586 Rename CipherString and CipherByteArray to EncString and EncByteArray

📊 Changes

35 files changed (+172 additions, -157 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+2 -2)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+1 -1)
📝 src/Core/Abstractions/IAzureFileUpoadService.cs (+2 -1)
📝 src/Core/Abstractions/ICryptoService.cs (+11 -11)
📝 src/Core/Abstractions/IFileUploadService.cs (+2 -2)
📝 src/Core/Abstractions/ISendService.cs (+2 -2)
📝 src/Core/Abstractions/IVaultTimeoutService.cs (+1 -1)
📝 src/Core/Models/Domain/Attachment.cs (+2 -2)
📝 src/Core/Models/Domain/Card.cs (+6 -6)
📝 src/Core/Models/Domain/Cipher.cs (+2 -2)
📝 src/Core/Models/Domain/Collection.cs (+1 -1)
📝 src/Core/Models/Domain/Domain.cs (+5 -5)
➕ src/Core/Models/Domain/EncByteArray.cs (+12 -0)
📝 src/Core/Models/Domain/EncString.cs (+3 -3)
📝 src/Core/Models/Domain/Field.cs (+2 -2)
📝 src/Core/Models/Domain/Folder.cs (+1 -1)
📝 src/Core/Models/Domain/Identity.cs (+18 -18)
📝 src/Core/Models/Domain/Login.cs (+3 -3)
📝 src/Core/Models/Domain/LoginUri.cs (+1 -1)
📝 src/Core/Models/Domain/PasswordHistory.cs (+1 -1)

...and 15 more files

📄 Description

Overview

Similar PR to bitwarden/jslib#346. There was no bug in this repository, but the tiny type protection is nice to translate over to mobile as well.

All of these changes constitute changing CipherService.EncrypteToBytes return value to CipherByteArray rather than byte[] and spidering that through change to maintain the type until it is uploaded to the server.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1366 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 4/14/2021 **Status:** ✅ Merged **Merged:** 4/21/2021 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `encrypt-to-encrypted-array-type` --- ### 📝 Commits (2) - [`b8b2acb`](https://github.com/bitwarden/android/commit/b8b2acbeb4abe9d2f860d25c7f433659dc06203c) Use CipherByteArray to signify encrypted byte[] - [`3afd586`](https://github.com/bitwarden/android/commit/3afd586ec233217c1d1f2751b61d40bdc931a5be) Rename CipherString and CipherByteArray to EncString and EncByteArray ### 📊 Changes **35 files changed** (+172 additions, -157 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+2 -2) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+1 -1) 📝 `src/Core/Abstractions/IAzureFileUpoadService.cs` (+2 -1) 📝 `src/Core/Abstractions/ICryptoService.cs` (+11 -11) 📝 `src/Core/Abstractions/IFileUploadService.cs` (+2 -2) 📝 `src/Core/Abstractions/ISendService.cs` (+2 -2) 📝 `src/Core/Abstractions/IVaultTimeoutService.cs` (+1 -1) 📝 `src/Core/Models/Domain/Attachment.cs` (+2 -2) 📝 `src/Core/Models/Domain/Card.cs` (+6 -6) 📝 `src/Core/Models/Domain/Cipher.cs` (+2 -2) 📝 `src/Core/Models/Domain/Collection.cs` (+1 -1) 📝 `src/Core/Models/Domain/Domain.cs` (+5 -5) ➕ `src/Core/Models/Domain/EncByteArray.cs` (+12 -0) 📝 `src/Core/Models/Domain/EncString.cs` (+3 -3) 📝 `src/Core/Models/Domain/Field.cs` (+2 -2) 📝 `src/Core/Models/Domain/Folder.cs` (+1 -1) 📝 `src/Core/Models/Domain/Identity.cs` (+18 -18) 📝 `src/Core/Models/Domain/Login.cs` (+3 -3) 📝 `src/Core/Models/Domain/LoginUri.cs` (+1 -1) 📝 `src/Core/Models/Domain/PasswordHistory.cs` (+1 -1) _...and 15 more files_ </details> ### 📄 Description # Overview Similar PR to bitwarden/jslib#346. There was no bug in this repository, but the tiny type protection is nice to translate over to mobile as well. All of these changes constitute changing `CipherService.EncrypteToBytes` return value to `CipherByteArray` rather than `byte[]` and spidering that through change to maintain the type until it is uploaded to the server. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:25:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2852
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?