github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1365] [MERGED] Password reprompt #2851

New Issue
Closed
opened 2025-11-26 23:24:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:58 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1365
Author: @Hinton
Created: 4/14/2021
Status: ✅ Merged
Merged: 5/21/2021
Merged by: @Hinton

Base: master ← Head: feature/password-reprompt

📝 Commits (10+)

  • 4c1d1a4 Make card number hidden
  • 672c6c2 Add support for password reprompt
  • f466f6f Rename PasswordPrompt to Reprompt
  • 5928425 Protect autofill
  • b5b41bc Use Enums.CipherRepromptType
  • fdb1c46 Fix iOS not building
  • 29b8f33 Merge branch 'feature/password-reprompt' of github.com:bitwarden/mobile into feature/password-reprompt
  • dec107d Protect iOS autofill
  • 2c4d6a1 Update to match jslib
  • 266cdeb Fix failing build

📊 Changes

36 files changed (+401 additions, -55 deletions)

View changed files

📝 src/Android/Autofill/AutofillHelpers.cs (+3 -2)
📝 src/Android/MainApplication.cs (+6 -0)
📝 src/Android/Services/DeviceActionService.cs (+5 -1)
📝 src/App/Abstractions/IDeviceActionService.cs (+1 -1)
➕ src/App/Abstractions/IPasswordRepromptService.cs (+11 -0)
📝 src/App/Pages/Vault/AddEditPage.xaml (+41 -5)
📝 src/App/Pages/Vault/AddEditPage.xaml.cs (+5 -0)
📝 src/App/Pages/Vault/AddEditPageViewModel.cs (+24 -0)
📝 src/App/Pages/Vault/AutofillCiphersPageViewModel.cs (+8 -2)
📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+4 -2)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+3 -1)
📝 src/App/Pages/Vault/ViewPage.xaml (+20 -3)
📝 src/App/Pages/Vault/ViewPage.xaml.cs (+24 -0)
📝 src/App/Pages/Vault/ViewPageViewModel.cs (+66 -5)
📝 src/App/Resources/AppResources.Designer.cs (+20 -0)
📝 src/App/Resources/AppResources.resx (+9 -0)
➕ src/App/Services/MobilePasswordRepromptService.cs (+46 -0)
📝 src/App/Services/MobilePlatformUtilsService.cs (+15 -0)
📝 src/App/Utilities/AppHelpers.cs (+30 -18)
📝 src/Core/Abstractions/IPlatformUtilsService.cs (+1 -0)

...and 16 more files

📄 Description

Objective

Adds support for requiring master password re-prompt before accessing hidden fields on ciphers. Also marks card numbers as a secret to ensure it's protected.

Code Changes

  • src/{Android, iOS}/Services/DeviceActionService.cs: Add support for prompting password.
  • src/App/Pages/Vault/AddEditPage.xaml, src/App/Pages/Vault/AddEditPage.xaml.cs: Change card number to be hidden, add toggle for password prompt.
  • src/App/Pages/Vault/AddEditPageViewModel.cs: Hook up toggle for card number, password prompts.
  • src/App/Pages/Vault/AutofillCiphersPageViewModel.cs, src/App/Pages/Vault/CiphersPageViewModel.cs, src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs: Hook in password reprompt service to CipherListOptions.
  • src/App/Pages/Vault/ViewPage.xaml: Change card number to be hidden.
  • src/App/Pages/Vault/ViewPage.xaml.cs: Prompt for password before showing/copying secrets.
  • src/App/Pages/Vault/ViewPageViewModel.cs: Card number toggle and password prompts.
  • src/App/Services/MobilePasswordRepromptService.cs: Service for prompting for passwords.
  • src/App/Utilities/AppHelpers.cs: Prompt for password before allowing access to protected items.

Testing Considerations

We should verify all expected values are protected and cannot be accessed without prompting for master password. Especially for autofill.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1365 **Author:** [@Hinton](https://github.com/Hinton) **Created:** 4/14/2021 **Status:** ✅ Merged **Merged:** 5/21/2021 **Merged by:** [@Hinton](https://github.com/Hinton) **Base:** `master` ← **Head:** `feature/password-reprompt` --- ### 📝 Commits (10+) - [`4c1d1a4`](https://github.com/bitwarden/android/commit/4c1d1a4402ad6f62888a98f905ebc4816c70e870) Make card number hidden - [`672c6c2`](https://github.com/bitwarden/android/commit/672c6c2febbe585afc3b0b59c5329bfeb2d733b5) Add support for password reprompt - [`f466f6f`](https://github.com/bitwarden/android/commit/f466f6fa50cfaa8a97591378653620195934e0c0) Rename PasswordPrompt to Reprompt - [`5928425`](https://github.com/bitwarden/android/commit/5928425c5f95343a90725dc941df4322f6dcf980) Protect autofill - [`b5b41bc`](https://github.com/bitwarden/android/commit/b5b41bc9673c6b81f4597a4a247c76e199de8ff5) Use Enums.CipherRepromptType - [`fdb1c46`](https://github.com/bitwarden/android/commit/fdb1c46f59c6f91fc5edbfdd52cfaa0a4f2b8214) Fix iOS not building - [`29b8f33`](https://github.com/bitwarden/android/commit/29b8f336a874cd96294bd75eea871751cd274436) Merge branch 'feature/password-reprompt' of github.com:bitwarden/mobile into feature/password-reprompt - [`dec107d`](https://github.com/bitwarden/android/commit/dec107d8663ae3c5b20db3bb0cf5b14e070ebec8) Protect iOS autofill - [`2c4d6a1`](https://github.com/bitwarden/android/commit/2c4d6a13142d1321928c5ceb93e078b85ab0212b) Update to match jslib - [`266cdeb`](https://github.com/bitwarden/android/commit/266cdebb99b7cb67462b745b0e0ad506569f6192) Fix failing build ### 📊 Changes **36 files changed** (+401 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/AutofillHelpers.cs` (+3 -2) 📝 `src/Android/MainApplication.cs` (+6 -0) 📝 `src/Android/Services/DeviceActionService.cs` (+5 -1) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+1 -1) ➕ `src/App/Abstractions/IPasswordRepromptService.cs` (+11 -0) 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+41 -5) 📝 `src/App/Pages/Vault/AddEditPage.xaml.cs` (+5 -0) 📝 `src/App/Pages/Vault/AddEditPageViewModel.cs` (+24 -0) 📝 `src/App/Pages/Vault/AutofillCiphersPageViewModel.cs` (+8 -2) 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+4 -2) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Vault/ViewPage.xaml` (+20 -3) 📝 `src/App/Pages/Vault/ViewPage.xaml.cs` (+24 -0) 📝 `src/App/Pages/Vault/ViewPageViewModel.cs` (+66 -5) 📝 `src/App/Resources/AppResources.Designer.cs` (+20 -0) 📝 `src/App/Resources/AppResources.resx` (+9 -0) ➕ `src/App/Services/MobilePasswordRepromptService.cs` (+46 -0) 📝 `src/App/Services/MobilePlatformUtilsService.cs` (+15 -0) 📝 `src/App/Utilities/AppHelpers.cs` (+30 -18) 📝 `src/Core/Abstractions/IPlatformUtilsService.cs` (+1 -0) _...and 16 more files_ </details> ### 📄 Description ## Objective Adds support for requiring master password re-prompt before accessing hidden fields on ciphers. Also marks card numbers as a secret to ensure it's protected. ### Code Changes - **src/{Android, iOS}/Services/DeviceActionService.cs**: Add support for prompting password. - **src/App/Pages/Vault/AddEditPage.xaml, src/App/Pages/Vault/AddEditPage.xaml.cs**: Change card number to be hidden, add toggle for password prompt. - **src/App/Pages/Vault/AddEditPageViewModel.cs**: Hook up toggle for card number, password prompts. - **src/App/Pages/Vault/AutofillCiphersPageViewModel.cs, src/App/Pages/Vault/CiphersPageViewModel.cs, src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs**: Hook in password reprompt service to CipherListOptions. - **src/App/Pages/Vault/ViewPage.xaml**: Change card number to be hidden. - **src/App/Pages/Vault/ViewPage.xaml.cs**: Prompt for password before showing/copying secrets. - **src/App/Pages/Vault/ViewPageViewModel.cs**: Card number toggle and password prompts. - **src/App/Services/MobilePasswordRepromptService.cs**: Service for prompting for passwords. - **src/App/Utilities/AppHelpers.cs**: Prompt for password before allowing access to protected items. ### Testing Considerations We should verify all expected values are protected and cannot be accessed without prompting for master password. Especially for autofill. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2851
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?