github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 13:14:35 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1313] [MERGED] Fix for incorrect deletion/expiration times during Send creation #2834

New Issue
Closed
opened 2025-11-26 23:24:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1313
Author: @mpbw2
Created: 3/12/2021
Status: ✅ Merged
Merged: 3/12/2021
Merged by: @mpbw2

Base: master ← Head: bugfix-send-datetimes

📝 Commits (1)

  • 45d05d9 fix for incorrect times during Send creation

📊 Changes

2 files changed (+32 additions, -34 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+31 -33)
📝 src/App/Resources/AppResources.resx (+1 -1)

📄 Description

When creating a new Send, the DateTimes created from the "simple" picker were being set to midnight instead of the current time. Not really a showstopper until "one hour" is selected, resulting in a DateTime from the past ([today] at midnight). Some investigation revealed that modifying the 'DeletionDate' property bound to ExtendedDatePicker was triggering property changes multiple times within the picker and resetting the time to midnight. Those custom pickers are no fun, so for safety/sanity during this release I've given the "simple" pickers their own "simple" DateTimes to modify, isolating them from the values bound to the custom pickers. I will revisit this later to come up with something more elegant.

Edit: Forgot to mention also fixed a missing "Send" capitalization

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1313 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/12/2021 **Status:** ✅ Merged **Merged:** 3/12/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-send-datetimes` --- ### 📝 Commits (1) - [`45d05d9`](https://github.com/bitwarden/android/commit/45d05d9a0cde3c6962bd7ac593d4b545c75397f5) fix for incorrect times during Send creation ### 📊 Changes **2 files changed** (+32 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+31 -33) 📝 `src/App/Resources/AppResources.resx` (+1 -1) </details> ### 📄 Description When creating a new Send, the DateTimes created from the "simple" picker were being set to midnight instead of the current time. Not really a showstopper until "one hour" is selected, resulting in a DateTime from the past ([today] at midnight). Some investigation revealed that modifying the 'DeletionDate' property bound to `ExtendedDatePicker` was triggering property changes multiple times within the picker and resetting the time to midnight. Those custom pickers are no fun, so for safety/sanity during this release I've given the "simple" pickers their own "simple" DateTimes to modify, isolating them from the values bound to the custom pickers. I will revisit this later to come up with something more elegant. Edit: Forgot to mention also fixed a missing "Send" capitalization --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2834
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?