github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1293] [MERGED] Send file model changes #2822

New Issue
Closed
opened 2025-11-26 23:24:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1293
Author: @MGibson1
Created: 3/1/2021
Status: ✅ Merged
Merged: 3/2/2021
Merged by: @MGibson1

Base: master ← Head: send-file-model-changes

📝 Commits (2)

  • 837a30c Remove Url from SendFile.
  • 8902884 Populate SendRequest file length

📊 Changes

8 files changed (+14 additions, -17 deletions)

View changed files

📝 src/Core/Models/Api/SendFileApi.cs (+0 -1)
📝 src/Core/Models/Data/SendFileData.cs (+0 -2)
📝 src/Core/Models/Domain/SendFile.cs (+1 -2)
📝 src/Core/Models/Request/SendRequest.cs (+4 -2)
📝 src/Core/Models/View/SendFileView.cs (+0 -2)
📝 src/Core/Services/SendService.cs (+1 -1)
📝 test/Core.Test/Models/Request/SendRequestTests.cs (+5 -4)
📝 test/Core.Test/Services/SendServiceTests.cs (+3 -3)

📄 Description

Overview

Related to bitwarden/server#1175. Updates models to match new expected lack of URL in SendFile and file length hint in SendRequest.

Files Changed

  • SendFileApi.cs/SendFileData.cs/SendFile.cs/SendFileView.cs: Remove Url
  • SendRequest.cs/SendService.csc Add and populate FileLength hint on initial Send Request
  • Tests: Populate File Length. Verifies SendRequest file length is correctly populated.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1293 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 3/1/2021 **Status:** ✅ Merged **Merged:** 3/2/2021 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `send-file-model-changes` --- ### 📝 Commits (2) - [`837a30c`](https://github.com/bitwarden/android/commit/837a30c75d95baee967d34fe144025c9975b57d5) Remove Url from SendFile. - [`8902884`](https://github.com/bitwarden/android/commit/89028848cb3fe0353fb80f88723c413aa59cdbf5) Populate SendRequest file length ### 📊 Changes **8 files changed** (+14 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/Api/SendFileApi.cs` (+0 -1) 📝 `src/Core/Models/Data/SendFileData.cs` (+0 -2) 📝 `src/Core/Models/Domain/SendFile.cs` (+1 -2) 📝 `src/Core/Models/Request/SendRequest.cs` (+4 -2) 📝 `src/Core/Models/View/SendFileView.cs` (+0 -2) 📝 `src/Core/Services/SendService.cs` (+1 -1) 📝 `test/Core.Test/Models/Request/SendRequestTests.cs` (+5 -4) 📝 `test/Core.Test/Services/SendServiceTests.cs` (+3 -3) </details> ### 📄 Description # Overview Related to bitwarden/server#1175. Updates models to match new expected lack of URL in SendFile and file length hint in SendRequest. # Files Changed * **SendFileApi.cs/SendFileData.cs/SendFile.cs/SendFileView.cs**: Remove Url * **SendRequest.cs/SendService.csc** Add and populate FileLength hint on initial Send Request * **Tests**: Populate File Length. Verifies SendRequest file length is correctly populated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2822
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?