github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1265] [MERGED] Expandable options for Add/Edit Send #2814

New Issue
Closed
opened 2025-11-26 23:24:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1265
Author: @mpbw2
Created: 2/16/2021
Status: ✅ Merged
Merged: 2/16/2021
Merged by: @mpbw2

Base: master ← Head: send-options

📝 Commits (1)

  • bbb215d options expander for send

📊 Changes

3 files changed (+285 additions, -217 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+266 -217)
📝 src/App/Pages/Send/SendAddEditPage.xaml.cs (+8 -0)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+11 -0)

📄 Description

Options section is collapsed by default when adding or editing Sends for simplification.

Considerations:

  • Share this Send upon save switch is the last element before the Options panel (instead of the very end of the form) since the Save button on mobile is at the top.
  • It's amazing how inconsistently apps us the "down" vs. "up" chevron to represent "expanded" vs. "collapsed". I chose the "action to be performed when pressing this button" approach, so "down" is "collapsed". I'm not super attached to it though if anybody has strong feelings otherwise. (Some UIs show a right-facing chevron to indicate collapsed, but on mobile that can drive an expectation that we'll be taken to the "next screen", which isn't what we're doing here. I'm probably overthinking it.)

Screenshots:

Screen Shot 2021-02-16 at 2 15 36 PM
Screen Shot 2021-02-16 at 2 15 41 PM
Screen Shot 2021-02-16 at 2 16 05 PM
Screen Shot 2021-02-16 at 2 16 08 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1265 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/16/2021 **Status:** ✅ Merged **Merged:** 2/16/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `send-options` --- ### 📝 Commits (1) - [`bbb215d`](https://github.com/bitwarden/android/commit/bbb215ddc57293fa63960e44105ed94cf6f85083) options expander for send ### 📊 Changes **3 files changed** (+285 additions, -217 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+266 -217) 📝 `src/App/Pages/Send/SendAddEditPage.xaml.cs` (+8 -0) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+11 -0) </details> ### 📄 Description Options section is collapsed by default when adding or editing Sends for simplification. **Considerations:** - `Share this Send upon save` switch is the last element before the Options panel (instead of the very end of the form) since the `Save` button on mobile is at the top. - It's amazing how inconsistently apps us the "down" vs. "up" chevron to represent "expanded" vs. "collapsed". I chose the "action to be performed when pressing this button" approach, so "down" is "collapsed". I'm not super attached to it though if anybody has strong feelings otherwise. (Some UIs show a right-facing chevron to indicate collapsed, but on mobile that can drive an expectation that we'll be taken to the "next screen", which isn't what we're doing here. I'm probably overthinking it.) **Screenshots:** ![Screen Shot 2021-02-16 at 2 15 36 PM](https://user-images.githubusercontent.com/59324545/108110955-0c46bb00-7062-11eb-9894-2d29bc104e43.png) ![Screen Shot 2021-02-16 at 2 15 41 PM](https://user-images.githubusercontent.com/59324545/108110962-0ea91500-7062-11eb-8191-d8e735b9df90.png) ![Screen Shot 2021-02-16 at 2 16 05 PM](https://user-images.githubusercontent.com/59324545/108110966-0fda4200-7062-11eb-8692-1e8a4d6b00fc.png) ![Screen Shot 2021-02-16 at 2 16 08 PM](https://user-images.githubusercontent.com/59324545/108110968-110b6f00-7062-11eb-8884-dd858ce40c0d.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2814
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?