github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 15:31:34 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1262] [MERGED] Send bugfixes & tweaks #2813

New Issue
Closed
opened 2025-11-26 23:24:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1262
Author: @mpbw2
Created: 2/12/2021
Status: ✅ Merged
Merged: 2/12/2021
Merged by: @mpbw2

Base: master ← Head: bugfixes

📝 Commits (2)

📊 Changes

3 files changed (+83 additions, -44 deletions)

View changed files

📝 src/App/Pages/Send/SendAddEditPage.xaml (+15 -15)
📝 src/App/Pages/Send/SendAddEditPage.xaml.cs (+12 -0)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+56 -29)

📄 Description

  • Fixed improper file field validation when editing a file Send
  • Fixed "no file chosen" label after selecting file
  • Fixed blank deletion date/time picker when current date is today or time is midnight
  • Fixed all Now references to have minute-precision (strip seconds & milliseconds)
  • Fixed Name field focus issue when switching between file and text types
  • Moved Name field above Send type picker per discussion

Screen Shot 2021-02-12 at 12 27 15 PM
Screen Shot 2021-02-12 at 12 27 24 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1262 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/12/2021 **Status:** ✅ Merged **Merged:** 2/12/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfixes` --- ### 📝 Commits (2) - [`3ca5cf3`](https://github.com/bitwarden/android/commit/3ca5cf34ece556056cefc9896a9700ff91326b91) bugfixes - [`f41f858`](https://github.com/bitwarden/android/commit/f41f858cd418d217761c995c616b5903fc64ecbe) request name focus only if field is empty ### 📊 Changes **3 files changed** (+83 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+15 -15) 📝 `src/App/Pages/Send/SendAddEditPage.xaml.cs` (+12 -0) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+56 -29) </details> ### 📄 Description - Fixed improper file field validation when editing a file Send - Fixed "no file chosen" label after selecting file - Fixed blank deletion date/time picker when current date is today or time is midnight - Fixed all `Now` references to have minute-precision (strip seconds & milliseconds) - Fixed `Name` field focus issue when switching between file and text types - Moved `Name` field above Send type picker per discussion ![Screen Shot 2021-02-12 at 12 27 15 PM](https://user-images.githubusercontent.com/59324545/107801115-ae4a6880-6d2d-11eb-823a-6c7b4b313587.png) ![Screen Shot 2021-02-12 at 12 27 24 PM](https://user-images.githubusercontent.com/59324545/107801119-af7b9580-6d2d-11eb-8949-b8478c8382f1.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2813
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?