github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1261] [MERGED] Added disabled icon and make File default type for new Sends if premium #2812

New Issue
Closed
opened 2025-11-26 23:24:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1261
Author: @mpbw2
Created: 2/11/2021
Status: ✅ Merged
Merged: 2/11/2021
Merged by: @mpbw2

Base: master ← Head: tweaks-send

📝 Commits (2)

  • 39fd7ea Added disabled icon and make File default type for new Sends if premium
  • 19779c2 forgot to expand colspan for extra icon

📊 Changes

3 files changed (+26 additions, -13 deletions)

View changed files

📝 src/App/Controls/SendViewCell/SendViewCell.xaml (+16 -4)
📝 src/App/Pages/Send/SendAddEditPage.xaml (+8 -8)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+2 -1)

📄 Description

  • Added "disabled" state icon fa-warning in lieu of banner to save space in Sends list
  • Swapped File and Text type buttons for new Sends
  • Made File the default new Send type for premium users

Screen Shot 2021-02-11 at 4 15 16 PM
Screen Shot 2021-02-11 at 3 56 33 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1261 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/11/2021 **Status:** ✅ Merged **Merged:** 2/11/2021 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `tweaks-send` --- ### 📝 Commits (2) - [`39fd7ea`](https://github.com/bitwarden/android/commit/39fd7ea84c8d6e22fa6d5d1d5557228ad344af35) Added disabled icon and make File default type for new Sends if premium - [`19779c2`](https://github.com/bitwarden/android/commit/19779c24e1cbfc15ef5b078353d50cc61521c0c4) forgot to expand colspan for extra icon ### 📊 Changes **3 files changed** (+26 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/SendViewCell/SendViewCell.xaml` (+16 -4) 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+8 -8) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+2 -1) </details> ### 📄 Description - Added "disabled" state icon `fa-warning` in lieu of banner to save space in Sends list - Swapped `File` and `Text` type buttons for new Sends - Made `File` the default new Send type for premium users ![Screen Shot 2021-02-11 at 4 15 16 PM](https://user-images.githubusercontent.com/59324545/107699663-615e8780-6c84-11eb-9bb1-07f8cae10729.png) ![Screen Shot 2021-02-11 at 3 56 33 PM](https://user-images.githubusercontent.com/59324545/107698262-44c15000-6c82-11eb-989a-ffc4dba90429.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?