github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1227] [MERGED] null checked all the permissions #2799

New Issue
Closed
opened 2025-11-26 23:24:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1227
Author: @addisonbeck
Created: 1/19/2021
Status: ✅ Merged
Merged: 1/19/2021
Merged by: @addisonbeck

Base: master ← Head: PermissionsFixes

📝 Commits (1)

  • 3d22376 null checked all the permissions

📊 Changes

3 files changed (+5 additions, -5 deletions)

View changed files

📝 src/Core/Models/Data/OrganizationData.cs (+2 -2)
📝 src/Core/Models/Domain/Organization.cs (+2 -2)
📝 src/Core/Models/Response/ProfileOrganizationResponse.cs (+1 -1)

📄 Description

Just as no boolean value should ever be nullable, so too should a collection of boolean values never be nullable

This fixes a bug in the Testflight release that was causing editing organization ciphers to crash the app.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1227 **Author:** [@addisonbeck](https://github.com/addisonbeck) **Created:** 1/19/2021 **Status:** ✅ Merged **Merged:** 1/19/2021 **Merged by:** [@addisonbeck](https://github.com/addisonbeck) **Base:** `master` ← **Head:** `PermissionsFixes` --- ### 📝 Commits (1) - [`3d22376`](https://github.com/bitwarden/android/commit/3d2237628d63da4251428b56a1fe3dc8d15c46b5) null checked all the permissions ### 📊 Changes **3 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/Data/OrganizationData.cs` (+2 -2) 📝 `src/Core/Models/Domain/Organization.cs` (+2 -2) 📝 `src/Core/Models/Response/ProfileOrganizationResponse.cs` (+1 -1) </details> ### 📄 Description Just as no boolean value should ever be nullable, so too should a collection of boolean values never be nullable This fixes a bug in the Testflight release that was causing editing organization ciphers to crash the app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2799
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?