github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1210] [MERGED] [Policy] Personal Ownership banner #2792

New Issue
Closed
opened 2025-11-26 23:24:09 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:09 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1210
Author: @vincentsalucci
Created: 1/6/2021
Status: ✅ Merged
Merged: 1/7/2021
Merged by: @vincentsalucci

Base: master ← Head: m-ownership-banner

📝 Commits (1)

  • 9da57a4 initial commit of ownership banner

📊 Changes

4 files changed (+40 additions, -13 deletions)

View changed files

📝 src/App/Pages/Vault/AddEditPage.xaml (+23 -0)
📝 src/App/Pages/Vault/AddEditPageViewModel.cs (+1 -0)
📝 src/App/Resources/AppResources.Designer.cs (+13 -13)
📝 src/App/Resources/AppResources.resx (+3 -0)

📄 Description

Objective

To clear up any confusion while the Personal Ownership policy is enabled and in effect, a banner has been added to the add-edit component. Mimic the password generator banner.

Code Changes

  • AddEditPage.xaml: added stylized banner
  • AddEditPageViewModel.cs: added OwnershipPolicyInEffect property for when to show the banner
  • AppResources.resx: added banner string

Screenshots

0-mobile-android-banner

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1210 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 1/6/2021 **Status:** ✅ Merged **Merged:** 1/7/2021 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-ownership-banner` --- ### 📝 Commits (1) - [`9da57a4`](https://github.com/bitwarden/android/commit/9da57a447021a6b6260114998b8af41cedc6ca85) initial commit of ownership banner ### 📊 Changes **4 files changed** (+40 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+23 -0) 📝 `src/App/Pages/Vault/AddEditPageViewModel.cs` (+1 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+13 -13) 📝 `src/App/Resources/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Objective > To clear up any confusion while the `Personal Ownership` policy is enabled and in effect, a banner has been added to the `add-edit` component. Mimic the password generator banner. ## Code Changes - **AddEditPage.xaml**: added stylized banner - **AddEditPageViewModel.cs**: added `OwnershipPolicyInEffect` property for when to show the banner - **AppResources.resx**: added banner string ## Screenshots ![0-mobile-android-banner](https://user-images.githubusercontent.com/26154748/103788795-de9f3880-5004-11eb-83af-e3801c280dd0.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:09 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2792
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?