github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1193] [MERGED] [Bug] Clone personal ownership #2789

New Issue
Closed
opened 2025-11-26 23:24:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1193
Author: @vincentsalucci
Created: 12/25/2020
Status: ✅ Merged
Merged: 12/29/2020
Merged by: @vincentsalucci

Base: master ← Head: m-bug-clone-personal-ownership

📝 Commits (1)

  • ce8bc36 Fix UI bug with cloning item while personal ownership is disabled

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/App/Pages/Vault/AddEditPageViewModel.cs (+5 -0)

📄 Description

Objective

Cloning a cipher when personal ownership is not allowed would result in an unexpected experience with the ownership list (nothing would be selected, but the personal option would be removed). Fix by adjusting logic for downstream changes in clone mode when personal ownership is not allowed.

Code Changes

  • AddEditPageViewModel: Added explicit check for null Organization ID on the cipher being edited and if allowing personal ownership was disabled - if so, the cipher's Organization ID will be updated to the (first) organization enforcing this policy forcing the necessary downstream UI updates for ownership/collection(s)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1193 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 12/25/2020 **Status:** ✅ Merged **Merged:** 12/29/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `master` ← **Head:** `m-bug-clone-personal-ownership` --- ### 📝 Commits (1) - [`ce8bc36`](https://github.com/bitwarden/android/commit/ce8bc36e0abb1218e7acc089ef6d10ca14ed52f3) Fix UI bug with cloning item while personal ownership is disabled ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AddEditPageViewModel.cs` (+5 -0) </details> ### 📄 Description ## Objective > Cloning a cipher when personal ownership is not allowed would result in an unexpected experience with the ownership list (nothing would be selected, but the personal option would be removed). Fix by adjusting logic for downstream changes in clone mode when personal ownership is not allowed. ## Code Changes - **AddEditPageViewModel**: Added explicit check for `null` Organization ID on the cipher being edited and if allowing personal ownership was disabled - if so, the cipher's Organization ID will be updated to the (first) organization enforcing this policy forcing the necessary downstream UI updates for ownership/collection(s) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2789
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?