github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1189] [MERGED] Implemented Custom role and permissions #2788

New Issue
Closed
opened 2025-11-26 23:24:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1189
Author: @addisonbeck
Created: 12/22/2020
Status: ✅ Merged
Merged: 1/13/2021
Merged by: @addisonbeck

Base: master ← Head: Permissions

📝 Commits (3)

  • ab3f976 Implemented Custom role and permissions
  • d52e1ef changed permissions to permissions model
  • 1d303bb added a semicolon

📊 Changes

7 files changed (+35 additions, -2 deletions)

View changed files

📝 src/Android/Autofill/AutofillService.cs (+1 -1)
📝 src/App/Pages/Vault/AddEditPageViewModel.cs (+1 -1)
📝 src/Core/Enums/OrganizationUserType.cs (+1 -0)
📝 src/Core/Models/Data/OrganizationData.cs (+2 -0)
➕ src/Core/Models/Data/Permissions.cs (+16 -0)
📝 src/Core/Models/Domain/Organization.cs (+12 -0)
📝 src/Core/Models/Response/ProfileOrganizationResponse.cs (+2 -0)

📄 Description

https://app.asana.com/0/1195018406457675/1153292148278664

Narrative

As a user, I would like to be able to configure another user with access to manage user/group/collection assignment without being able to see organization passwords that are not directly assigned to them.

Code Changes

  1. Implemented the Permissions object and Custom role type as seen in the server PR
  2. Converted any existing role checks in the app to Permission checks that verify a ValidRole || ValidPermission

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1189 **Author:** [@addisonbeck](https://github.com/addisonbeck) **Created:** 12/22/2020 **Status:** ✅ Merged **Merged:** 1/13/2021 **Merged by:** [@addisonbeck](https://github.com/addisonbeck) **Base:** `master` ← **Head:** `Permissions` --- ### 📝 Commits (3) - [`ab3f976`](https://github.com/bitwarden/android/commit/ab3f976e3da191bc5d2963792e366338ca019331) Implemented Custom role and permissions - [`d52e1ef`](https://github.com/bitwarden/android/commit/d52e1ef297ad31d84bb7f21e917f745c7c61e76b) changed permissions to permissions model - [`1d303bb`](https://github.com/bitwarden/android/commit/1d303bbd93d6dbe7837808da04babe399fe67cd2) added a semicolon ### 📊 Changes **7 files changed** (+35 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Autofill/AutofillService.cs` (+1 -1) 📝 `src/App/Pages/Vault/AddEditPageViewModel.cs` (+1 -1) 📝 `src/Core/Enums/OrganizationUserType.cs` (+1 -0) 📝 `src/Core/Models/Data/OrganizationData.cs` (+2 -0) ➕ `src/Core/Models/Data/Permissions.cs` (+16 -0) 📝 `src/Core/Models/Domain/Organization.cs` (+12 -0) 📝 `src/Core/Models/Response/ProfileOrganizationResponse.cs` (+2 -0) </details> ### 📄 Description https://app.asana.com/0/1195018406457675/1153292148278664 ### Narrative As a user, I would like to be able to configure another user with access to manage user/group/collection assignment without being able to see organization passwords that are not directly assigned to them. ### Code Changes 1. Implemented the Permissions object and Custom role type as seen in the server PR 2. Converted any existing role checks in the app to Permission checks that verify a `ValidRole || ValidPermission` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?