github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1187] [MERGED] [SupportedBrowsers] Small update #2786

New Issue
Closed
opened 2025-11-26 23:24:05 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:05 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1187
Author: @contribucious
Created: 12/20/2020
Status: ✅ Merged
Merged: 12/21/2020
Merged by: @cscharf

Base: master ← Head: SupportedBrowsers--small-update

📝 Commits (4)

  • c28af6c [SupportedBrowsers] Small update
  • 3ed6849 Remove org.ungoogled.chromium from AutofillHelpers.CompatBrowsers too
  • b5d156d Remove org.ungoogled.chromium from autofillservice.xml too
  • 819b389 url -> URL

📊 Changes

3 files changed (+7 additions, -11 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+7 -7)
📝 src/Android/Autofill/AutofillHelpers.cs (+0 -1)
📝 src/Android/Resources/xml/autofillservice.xml (+0 -3)

📄 Description

This:

[~]

  • switches the order of priority "Fennec,Fenix" to "Fenix,Fennec" for org.torproject.torbrowser (see their blog post and annex 1 below).

[+]

  • adds a precision about the non-presence in this list of com.android.htmlviewer (entry added by @stevenlele in this PR).

[-]

  • removes the deprecated org.ungoogled.chromium as planned here;
  • removes unnecessary precision about the version regarding some entries added by @stevenlele (for the sake of clarity, let's only add this information in the source code itself when more than one resource-id is present — typical case: current and legacy value).
     
     
Annex 1 …

Freshly downloaded APK (v10.0.7)

$ strings -f "org.torproject.torbrowser_10.0.7_(84.1.0-Release)-2015737923_minAPI21(arm64-v8a)(nodpi)_apkmirror.com.apk" | egrep "url_bar_title|mozac_browser_toolbar_url_view"
org.torproject.torbrowser_10.0.7_(84.1.0-Release)-2015737923_minAPI21(arm64-v8a)(nodpi)_apkmirror.com.apk: mozac_browser_toolbar_url_view

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1187 **Author:** [@contribucious](https://github.com/contribucious) **Created:** 12/20/2020 **Status:** ✅ Merged **Merged:** 12/21/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `SupportedBrowsers--small-update` --- ### 📝 Commits (4) - [`c28af6c`](https://github.com/bitwarden/android/commit/c28af6cb802881dbc4dda74a2bffc4b7b18758d1) [SupportedBrowsers] Small update - [`3ed6849`](https://github.com/bitwarden/android/commit/3ed68498495731ff03a47969d55d6acdefd001c9) Remove `org.ungoogled.chromium` from AutofillHelpers.CompatBrowsers too - [`b5d156d`](https://github.com/bitwarden/android/commit/b5d156db25a0e14a94437273f9ca9931d95c94d4) Remove `org.ungoogled.chromium` from autofillservice.xml too - [`819b389`](https://github.com/bitwarden/android/commit/819b389ac6607d2c37d6066461ae564eb417689b) url -> URL ### 📊 Changes **3 files changed** (+7 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+7 -7) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+0 -1) 📝 `src/Android/Resources/xml/autofillservice.xml` (+0 -3) </details> ### 📄 Description # This: ### [~] - switches the order of priority "Fennec,Fenix" to "Fenix,Fennec" for `org.torproject.torbrowser` (see their [blog post](https://blog.torproject.org/new-release-tor-browser-1003) and annex 1 below). ### [+] - adds a precision about the non-presence in this list of `com.android.htmlviewer` (entry added by @stevenlele in [this PR](https://github.com/bitwarden/mobile/pull/1121)). ### [-] - removes the deprecated `org.ungoogled.chromium` as planned [here](https://github.com/bitwarden/mobile/pull/1119); - removes unnecessary precision about the version regarding some entries added by @stevenlele (for the sake of clarity, let's only add this information in the source code itself when more than one resource-id is present — typical case: current and legacy value). &nbsp; &nbsp; ___ <details> <summary>Annex 1 …</summary> # Freshly downloaded APK (v10.0.7) ```bash $ strings -f "org.torproject.torbrowser_10.0.7_(84.1.0-Release)-2015737923_minAPI21(arm64-v8a)(nodpi)_apkmirror.com.apk" | egrep "url_bar_title|mozac_browser_toolbar_url_view" org.torproject.torbrowser_10.0.7_(84.1.0-Release)-2015737923_minAPI21(arm64-v8a)(nodpi)_apkmirror.com.apk: mozac_browser_toolbar_url_view ``` </details> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:05 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2786
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?