github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1186] [MERGED] Attempt URI healing with https prior to http #2785

New Issue
Closed
opened 2025-11-26 23:24:04 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:04 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1186
Author: @MGibson1
Created: 12/18/2020
Status: ✅ Merged
Merged: 12/21/2020
Merged by: @MGibson1

Base: master ← Head: attempt-https-prepend-for-accessibility-uri-fixing

📝 Commits (2)

  • 1a8022a Attempt URI healing with https prior to http
  • 0a2577c Just use https as the URI healing scheme

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+3 -3)

📄 Description

Overview

Related to #1021.

Browsers are moving away from displaying URI scheme in a way accessibility can easily grab. This causes this URI healing to be relied upon more frequently. It should attempt https prior to http due to prevelence of https and security concerns with passwords over http.

Files changed

  • AccessibilityHelpers.cs: This helper is responsible for grabbing the Uri out of a browser's address node. If a URI scheme isn't present, it heals the URI with https://. It seems unlikely that any URI that isn't healed by https:// would be by prepending http://, but the attempt isn't very expensive.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1186 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 12/18/2020 **Status:** ✅ Merged **Merged:** 12/21/2020 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `attempt-https-prepend-for-accessibility-uri-fixing` --- ### 📝 Commits (2) - [`1a8022a`](https://github.com/bitwarden/android/commit/1a8022aafc8127a20547cb5d4c4c3d3311bf1fbb) Attempt URI healing with https prior to http - [`0a2577c`](https://github.com/bitwarden/android/commit/0a2577ce6d0446b3a34ce32b87eba217df2768f7) Just use https as the URI healing scheme ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+3 -3) </details> ### 📄 Description # Overview Related to #1021. Browsers are moving away from displaying URI scheme in a way accessibility can easily grab. This causes this URI healing to be relied upon more frequently. It should attempt https prior to http due to prevelence of https and security concerns with passwords over http. # Files changed * **AccessibilityHelpers.cs**: This helper is responsible for grabbing the Uri out of a browser's address node. If a URI scheme isn't present, it heals the URI with `https://`. It seems unlikely that any URI that isn't healed by `https://` would be by prepending `http://`, but the attempt isn't very expensive. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:04 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2785
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?