github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1185] [MERGED] Show vault export warning as popup #2784

New Issue
Closed
opened 2025-11-26 23:24:03 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:24:03 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1185
Author: @MGibson1
Created: 12/18/2020
Status: ✅ Merged
Merged: 12/18/2020
Merged by: @MGibson1

Base: master ← Head: vault-export-warning-as-popup

📝 Commits (1)

  • 7044156 Show vault export warning as popup

📊 Changes

4 files changed (+42 additions, -36 deletions)

View changed files

📝 src/App/Pages/Settings/ExportVaultPage.xaml (+0 -13)
📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+29 -22)
📝 src/App/Resources/AppResources.Designer.cs (+8 -0)
📝 src/App/Resources/AppResources.resx (+5 -1)

📄 Description

Overview

We decided with the subtle change between export warnings to use a confirmation popup to warn about the failings of each export type.

This PR removes the view's warning message and renders it as a popup after the master password has been confirmed. Ialso inverted the password if/else to minimize nesting.

Screenshots

Json export -- unencrypted warning

image

encrypted export -- encrypted warning

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1185 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 12/18/2020 **Status:** ✅ Merged **Merged:** 12/18/2020 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `vault-export-warning-as-popup` --- ### 📝 Commits (1) - [`7044156`](https://github.com/bitwarden/android/commit/7044156611304f1308219ef45c4802fae691bd15) Show vault export warning as popup ### 📊 Changes **4 files changed** (+42 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/ExportVaultPage.xaml` (+0 -13) 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+29 -22) 📝 `src/App/Resources/AppResources.Designer.cs` (+8 -0) 📝 `src/App/Resources/AppResources.resx` (+5 -1) </details> ### 📄 Description # Overview We decided with the subtle change between export warnings to use a confirmation popup to warn about the failings of each export type. This PR removes the view's warning message and renders it as a popup after the master password has been confirmed. Ialso inverted the password `if/else` to minimize nesting. # Screenshots ### Json export -- unencrypted warning <img width="423" alt="image" src="https://user-images.githubusercontent.com/18214891/102666388-6a335100-414c-11eb-942d-156f7959380f.png"> ### encrypted export -- encrypted warning <img width="423" alt="image" src="https://user-images.githubusercontent.com/18214891/102666815-75d34780-414d-11eb-8bc4-5d8cd95a0bbe.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:03 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2784
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?