[PR #1174] [MERGED] Enable Encrypted json export of vaults #2780

Closed
opened 2025-11-26 23:24:00 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1174
Author: @MGibson1
Created: 12/11/2020
Status: Merged
Merged: 12/14/2020
Merged by: @MGibson1

Base: masterHead: enable-encrypted-export


📝 Commits (4)

  • 69c792a Enable Encrypted json export of vaults
  • d15c190 Match jslib export of non-org ciphers
  • dcc5c46 Clean up export
  • d8352ff Update src/App/Pages/Settings/ExportVaultPage.xaml.cs

📊 Changes

18 files changed (+242 additions, -54 deletions)

View changed files

📝 src/App/Pages/Settings/ExportVaultPage.xaml (+2 -1)
📝 src/App/Pages/Settings/ExportVaultPage.xaml.cs (+5 -0)
📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+30 -1)
📝 src/App/Resources/AppResources.Designer.cs (+11 -1)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/Core/Models/Export/Card.cs (+10 -0)
📝 src/Core/Models/Export/Cipher.cs (+28 -0)
📝 src/Core/Models/Export/CipherWithId.cs (+7 -1)
📝 src/Core/Models/Export/Collection.cs (+7 -0)
📝 src/Core/Models/Export/CollectionWithId.cs (+5 -0)
📝 src/Core/Models/Export/Field.cs (+7 -0)
📝 src/Core/Models/Export/Folder.cs (+5 -0)
📝 src/Core/Models/Export/FolderWithId.cs (+5 -0)
📝 src/Core/Models/Export/Identity.cs (+22 -0)
📝 src/Core/Models/Export/Login.cs (+9 -0)
📝 src/Core/Models/Export/LoginUri.cs (+6 -0)
📝 src/Core/Models/Export/SecureNote.cs (+5 -0)
📝 src/Core/Services/ExportService.cs (+75 -50)

📄 Description

Overview

Allow for exporting vaults in an encrypted state.

File changes

  • ExportVaultPage.xaml/ExportVaultPage.xaml.cs/ExportVaultPageViewModel.cs: Add binding to update export warning message to appropriate message depending on export format.
  • AppResources.resx: Add encrypted export warning message (matches jslib's)
  • Models/Export/*: Update constructors to allow export of encrypted Domain types.

Image

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1174 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 12/11/2020 **Status:** ✅ Merged **Merged:** 12/14/2020 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `enable-encrypted-export` --- ### 📝 Commits (4) - [`69c792a`](https://github.com/bitwarden/android/commit/69c792a6ee50bf41919aa667f0b6e071063167db) Enable Encrypted json export of vaults - [`d15c190`](https://github.com/bitwarden/android/commit/d15c1903ea0802b3f529d632e9499c543e614d66) Match jslib export of non-org ciphers - [`dcc5c46`](https://github.com/bitwarden/android/commit/dcc5c46e4ce7cb633e6bf0406bcf9748f6ee4f2f) Clean up export - [`d8352ff`](https://github.com/bitwarden/android/commit/d8352ffdd8e061b26554a5927d25f931a00da7da) Update src/App/Pages/Settings/ExportVaultPage.xaml.cs ### 📊 Changes **18 files changed** (+242 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/ExportVaultPage.xaml` (+2 -1) 📝 `src/App/Pages/Settings/ExportVaultPage.xaml.cs` (+5 -0) 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+30 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+11 -1) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/Core/Models/Export/Card.cs` (+10 -0) 📝 `src/Core/Models/Export/Cipher.cs` (+28 -0) 📝 `src/Core/Models/Export/CipherWithId.cs` (+7 -1) 📝 `src/Core/Models/Export/Collection.cs` (+7 -0) 📝 `src/Core/Models/Export/CollectionWithId.cs` (+5 -0) 📝 `src/Core/Models/Export/Field.cs` (+7 -0) 📝 `src/Core/Models/Export/Folder.cs` (+5 -0) 📝 `src/Core/Models/Export/FolderWithId.cs` (+5 -0) 📝 `src/Core/Models/Export/Identity.cs` (+22 -0) 📝 `src/Core/Models/Export/Login.cs` (+9 -0) 📝 `src/Core/Models/Export/LoginUri.cs` (+6 -0) 📝 `src/Core/Models/Export/SecureNote.cs` (+5 -0) 📝 `src/Core/Services/ExportService.cs` (+75 -50) </details> ### 📄 Description # Overview Allow for exporting vaults in an encrypted state. # File changes * **ExportVaultPage.xaml/ExportVaultPage.xaml.cs/ExportVaultPageViewModel.cs**: Add binding to update export warning message to appropriate message depending on export format. * **AppResources.resx**: Add encrypted export warning message (matches jslib's) * **Models/Export/\***: Update constructors to allow export of encrypted Domain types. # Image ![image](https://user-images.githubusercontent.com/18214891/102114021-5eb7f100-3dff-11eb-870f-4d39ec02ac79.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:24:00 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2780