github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1172] [MERGED] Change text for clearing a clipboard to a space instead of an empty string on Android #2779

New Issue
Closed
opened 2025-11-26 23:23:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1172
Author: @lynshi
Created: 12/10/2020
Status: ✅ Merged
Merged: 12/10/2020
Merged by: @mpbw2

Base: master ← Head: master

📝 Commits (1)

  • cd9ad18 Change clipboard clear text to "" instead of string.Empty.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Android/Receivers/ClearClipboardAlarmReceiver.cs (+1 -1)

📄 Description

Per #1165, on Android 11 the Google Keyboard will suggest passwords copied to the clipboard even after they have been cleared by Bitwarden.

This is because the latest suggestion is not updated after the primary text on the clipboard is set to an empty string. The suggestion is removed correctly if the clipboard clear text is a space instead. Using a space to clear the clipboard matches the behavior of the Chromium browser extension.

This is what the suggestion looks like after Bitwarden has set the text in the clipboard to a space.
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1172 **Author:** [@lynshi](https://github.com/lynshi) **Created:** 12/10/2020 **Status:** ✅ Merged **Merged:** 12/10/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`cd9ad18`](https://github.com/bitwarden/android/commit/cd9ad18dd2dd4ac5f4204cff284e769ef1168856) Change clipboard clear text to "<space>" instead of `string.Empty`. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Receivers/ClearClipboardAlarmReceiver.cs` (+1 -1) </details> ### 📄 Description Per #1165, on Android 11 the Google Keyboard will suggest passwords copied to the clipboard even after they have been cleared by Bitwarden. This is because the latest suggestion is not updated after the primary text on the clipboard is set to an empty string. The suggestion is removed correctly if the clipboard clear text is a space instead. Using a space to clear the clipboard matches the behavior of the Chromium browser extension. This is what the suggestion looks like after Bitwarden has set the text in the clipboard to a space. ![image](https://user-images.githubusercontent.com/9373058/101730441-de943300-3a6e-11eb-9f74-be14516f79bd.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?