github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1152] [MERGED] Include revision date in cipher requests #2772

New Issue
Closed
opened 2025-11-26 23:23:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1152
Author: @MGibson1
Created: 11/17/2020
Status: ✅ Merged
Merged: 11/23/2020
Merged by: @MGibson1

Base: master ← Head: validate-cipher-updates-with-revision-date

📝 Commits (1)

  • 542c457 Include revision date in cipher requests

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 src/Core/Models/Request/CipherRequest.cs (+3 -0)
📝 src/Core/Services/CipherService.cs (+2 -1)

📄 Description

Objective

This is a companion PR to API changes found in bitwarden/server#994

Code Changes

  • CipherRequest.cs: Add revision date to request model for validation.
  • CipherService.cs: Include revision date in encryption of ciphers so it can be included in the request model.

Prereqs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1152 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 11/17/2020 **Status:** ✅ Merged **Merged:** 11/23/2020 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `validate-cipher-updates-with-revision-date` --- ### 📝 Commits (1) - [`542c457`](https://github.com/bitwarden/android/commit/542c457491e920c2a13b0115f7d418d5ebbb203a) Include revision date in cipher requests ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Models/Request/CipherRequest.cs` (+3 -0) 📝 `src/Core/Services/CipherService.cs` (+2 -1) </details> ### 📄 Description # Objective This is a companion PR to API changes found in bitwarden/server#994 # Code Changes * **CipherRequest.cs**: Add revision date to request model for validation. * **CipherService.cs**: Include revision date in encryption of ciphers so it can be included in the request model. # Prereqs - [ ] Merge in bitwarden/server#994 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2772
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?