github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1150] [MERGED] Enhanced autofill settings #2771

New Issue
Closed
opened 2025-11-26 23:23:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1150
Author: @mpbw2
Created: 11/14/2020
Status: ✅ Merged
Merged: 11/17/2020
Merged by: @mpbw2

Base: master ← Head: android-autofill-settings

📝 Commits (2)

📊 Changes

40 files changed (+533 additions, -391 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityService.cs (+4 -4)
📝 src/Android/Android.csproj (+0 -18)
📝 src/Android/Autofill/AutofillHelpers.cs (+2 -2)
📝 src/Android/Autofill/AutofillService.cs (+3 -1)
➖ src/Android/Resources/drawable-hdpi/accessibility_overlay.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/accessibility_permission.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/accessibility_step1.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/accessibility_step2.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/autofill_enable.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/autofill_use.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/accessibility_overlay.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/accessibility_permission.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/accessibility_step1.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/accessibility_step2.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/autofill_enable.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/autofill_use.png (+0 -0)
➖ src/Android/Resources/drawable-xxhdpi/accessibility_overlay.png (+0 -0)
➖ src/Android/Resources/drawable-xxhdpi/accessibility_permission.png (+0 -0)
➖ src/Android/Resources/drawable-xxhdpi/accessibility_step1.png (+0 -0)
➖ src/Android/Resources/drawable-xxhdpi/accessibility_step2.png (+0 -0)

...and 20 more files

📄 Description

Reworked autofill settings screen to explain settings in greater detail depending on the Android version. UI also matches paradigm defined throughout other settings screens.

A single Autofill Services section indicates Enabled if the combination of enabled settings are ready for use on a given version of Android:

settings

The phrasing for each setting is tweaked according to the capabilities & requirements of the given version of Android...

Android 11 (offers all options):

android_11

Android 8-10 (removal of inline autofill support):

android_8-10

Android 7 (only offers accessibility, support for quick-action autofill panel makes draw-over optional):

android_7

Android 6 (only offers accessibility, manual draw-over grant required):

android_6

Android 5 (only offers accessibility, draw-over on by default):

android_5

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1150 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 11/14/2020 **Status:** ✅ Merged **Merged:** 11/17/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `android-autofill-settings` --- ### 📝 Commits (2) - [`f5b5f1d`](https://github.com/bitwarden/android/commit/f5b5f1ded6301d61475b6243ce2ebbfa382fb766) enhanced autofill settings - [`93dff0f`](https://github.com/bitwarden/android/commit/93dff0fba1d3d4e9e8661c31cccd4f2ba0b8f76d) cleanup ### 📊 Changes **40 files changed** (+533 additions, -391 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityService.cs` (+4 -4) 📝 `src/Android/Android.csproj` (+0 -18) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+2 -2) 📝 `src/Android/Autofill/AutofillService.cs` (+3 -1) ➖ `src/Android/Resources/drawable-hdpi/accessibility_overlay.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/accessibility_permission.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/accessibility_step1.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/accessibility_step2.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/autofill_enable.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/autofill_use.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/accessibility_overlay.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/accessibility_permission.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/accessibility_step1.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/accessibility_step2.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/autofill_enable.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/autofill_use.png` (+0 -0) ➖ `src/Android/Resources/drawable-xxhdpi/accessibility_overlay.png` (+0 -0) ➖ `src/Android/Resources/drawable-xxhdpi/accessibility_permission.png` (+0 -0) ➖ `src/Android/Resources/drawable-xxhdpi/accessibility_step1.png` (+0 -0) ➖ `src/Android/Resources/drawable-xxhdpi/accessibility_step2.png` (+0 -0) _...and 20 more files_ </details> ### 📄 Description Reworked autofill settings screen to explain settings in greater detail depending on the Android version. UI also matches paradigm defined throughout other settings screens. A single `Autofill Services` section indicates `Enabled` if the combination of enabled settings are ready for use on a given version of Android: ![settings](https://user-images.githubusercontent.com/59324545/99132504-77f13600-25e4-11eb-9139-c8ff61c24561.png) The phrasing for each setting is tweaked according to the capabilities & requirements of the given version of Android... Android 11 (offers all options): ![android_11](https://user-images.githubusercontent.com/59324545/99132535-9e16d600-25e4-11eb-8b79-5cdc43fcde29.png) Android 8-10 (removal of inline autofill support): ![android_8-10](https://user-images.githubusercontent.com/59324545/99132551-aff87900-25e4-11eb-91b3-82b50cd62c03.png) Android 7 (only offers accessibility, support for quick-action autofill panel makes draw-over optional): ![android_7](https://user-images.githubusercontent.com/59324545/99132558-b5ee5a00-25e4-11eb-9216-34772a8eb1ab.png) Android 6 (only offers accessibility, manual draw-over grant required): ![android_6](https://user-images.githubusercontent.com/59324545/99132567-bb4ba480-25e4-11eb-8df8-ae2a25712da7.png) Android 5 (only offers accessibility, draw-over on by default): ![android_5](https://user-images.githubusercontent.com/59324545/99132578-c56da300-25e4-11eb-9aa9-20e1eb00137c.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2771
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?