github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 05:34:14 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1145] [MERGED] Android 11 inline autofill #2766

New Issue
Closed
opened 2025-11-26 23:23:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:48 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1145
Author: @mpbw2
Created: 11/10/2020
Status: ✅ Merged
Merged: 11/10/2020
Merged by: @mpbw2

Base: master ← Head: android11-autofill

📝 Commits (7)

  • 2657495 Inline autofill support for Android 11 - initial commit
  • 17a989b null check intent before getting bool extra
  • ad5ec15 Updated xamarin androidx autofill
  • 96a97c9 fixed broken overlay fallback
  • de7c7ff fixed filename
  • 6699a54 auto-compat-check cleanup
  • 14719f8 simplification

📊 Changes

8 files changed (+177 additions, -23 deletions)

View changed files

📝 src/Android/Android.csproj (+2 -1)
📝 src/Android/Autofill/AutofillHelpers.cs (+168 -16)
📝 src/Android/Autofill/AutofillService.cs (+1 -1)
📝 src/Android/Autofill/FilledItem.cs (+1 -1)
📝 src/Android/Properties/AndroidManifest.xml (+1 -1)
📝 src/Android/Resources/xml/autofillservice.xml (+2 -1)
📝 src/Android/Services/DeviceActionService.cs (+2 -2)
📝 src/App/Pages/Settings/AutofillServicePageViewModel.cs (+0 -0)

📄 Description

Support for Android 11 inline autofill. If a fill request includes an InlineSuggestionsRequest (requires Android 11 plus an IME (keyboard) that supports inline presentations) then we construct the additional views according to the given restrictions (dictated by the IME within the request) and returned along with the original overlay views. The result is a horizontally-scrollable collection of ciphers anchored within the IME. The original overlay is used if no InlineSuggestionsRequest is supplied, or if anything goes wrong during the creation of the inline presentation.

Some tidbits:

  • With the exception of our logo, the inline icons are tinted according to the rules in the InlineSuggestionsRequest to allow the IME to drive the theme.
  • With some browsers this can be finicky if the browser's own autofill functions are still enabled (varies, of course)
  • Firefox (prod & beta) is currently broken as it keeps re-initializing the keyboard and erasing the inline presentation. This has been fixed in their nightly builds.

Screen Shot 2020-11-10 at 11 39 30 AM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1145 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 11/10/2020 **Status:** ✅ Merged **Merged:** 11/10/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `android11-autofill` --- ### 📝 Commits (7) - [`2657495`](https://github.com/bitwarden/android/commit/2657495494f8cb5118ddfad442c7913b13b31bf0) Inline autofill support for Android 11 - initial commit - [`17a989b`](https://github.com/bitwarden/android/commit/17a989ba8242fc63767b44d72431424904bad022) null check intent before getting bool extra - [`ad5ec15`](https://github.com/bitwarden/android/commit/ad5ec153df054db15097e31a97012cf162b8d51b) Updated xamarin androidx autofill - [`96a97c9`](https://github.com/bitwarden/android/commit/96a97c920ea2fb98f4fee18ab1e501f86e96da3b) fixed broken overlay fallback - [`de7c7ff`](https://github.com/bitwarden/android/commit/de7c7ff96845f3e66070af7cb90d821fd702b12c) fixed filename - [`6699a54`](https://github.com/bitwarden/android/commit/6699a548b33d1283ab5f04988caee64e0567e007) auto-compat-check cleanup - [`14719f8`](https://github.com/bitwarden/android/commit/14719f89b292da8dea53eac7893e31d221e5c249) simplification ### 📊 Changes **8 files changed** (+177 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+2 -1) 📝 `src/Android/Autofill/AutofillHelpers.cs` (+168 -16) 📝 `src/Android/Autofill/AutofillService.cs` (+1 -1) 📝 `src/Android/Autofill/FilledItem.cs` (+1 -1) 📝 `src/Android/Properties/AndroidManifest.xml` (+1 -1) 📝 `src/Android/Resources/xml/autofillservice.xml` (+2 -1) 📝 `src/Android/Services/DeviceActionService.cs` (+2 -2) 📝 `src/App/Pages/Settings/AutofillServicePageViewModel.cs` (+0 -0) </details> ### 📄 Description Support for Android 11 inline autofill. If a fill request includes an `InlineSuggestionsRequest` (requires Android 11 plus an IME (keyboard) that supports inline presentations) then we construct the additional views according to the given restrictions (dictated by the IME within the request) and returned along with the original overlay views. The result is a horizontally-scrollable collection of ciphers anchored within the IME. The original overlay is used if no `InlineSuggestionsRequest` is supplied, or if anything goes wrong during the creation of the inline presentation. Some tidbits: - With the exception of our logo, the inline icons are tinted according to the rules in the `InlineSuggestionsRequest` to allow the IME to drive the theme. - With some browsers this can be finicky if the browser's own autofill functions are still enabled (varies, of course) - Firefox (prod & beta) is currently broken as it keeps re-initializing the keyboard and erasing the inline presentation. This has been fixed in their nightly builds. ![Screen Shot 2020-11-10 at 11 39 30 AM](https://user-images.githubusercontent.com/59324545/98703734-d484f480-2349-11eb-8065-12e4a5ea5c2e.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2766
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?