github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1133] [MERGED] Replacement of bitmap icons with vector versions (Android) #2761

New Issue
Closed
opened 2025-11-26 23:23:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1133
Author: @mpbw2
Created: 11/2/2020
Status: ✅ Merged
Merged: 11/2/2020
Merged by: @mpbw2

Base: master ← Head: vectorization

📝 Commits (1)

  • f64ec49 Replacement of bitmap icons with vector versions (Android)

📊 Changes

88 files changed (+161 additions, -195 deletions)

View changed files

📝 src/Android/Android.csproj (+20 -192)
➖ src/Android/Resources/drawable-hdpi/card.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/cog.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/id.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/lock.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/login.png (+0 -0)
📝 src/Android/Resources/drawable-hdpi/logo_legacy.png (+0 -0)
📝 src/Android/Resources/drawable-hdpi/logo_white_legacy.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/pencil.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/plus.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/refresh.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/refresh_sm.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/search.png (+0 -0)
➖ src/Android/Resources/drawable-hdpi/shield.png (+0 -0)
➕ src/Android/Resources/drawable-v23/splash_screen.xml (+15 -0)
➕ src/Android/Resources/drawable-v23/splash_screen_dark.xml (+15 -0)
➖ src/Android/Resources/drawable-xhdpi/card.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/cog.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/id.png (+0 -0)
➖ src/Android/Resources/drawable-xhdpi/lock.png (+0 -0)

...and 68 more files

📄 Description

Replacement of bitmap icons with vector drawables. This gives us flexibility with theming as scaling & tinting becomes programmatically possible, not to mention the ease of adjustments going forward as there is no longer a need to export multiple bitmaps if/when a change is required.

(This started as part of Android 11 autofill since the icons weren't as sharp as they could be within the InlinePresentation. However as I'm now waiting for an update to Xamarin's AndroidX package, I moved on and did all the icons.)

01_splash
02_vault
03_vault_dark
04_tiles

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1133 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 11/2/2020 **Status:** ✅ Merged **Merged:** 11/2/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `vectorization` --- ### 📝 Commits (1) - [`f64ec49`](https://github.com/bitwarden/android/commit/f64ec49a88ac96dda507694b4e500a19a56a88f0) Replacement of bitmap icons with vector versions (Android) ### 📊 Changes **88 files changed** (+161 additions, -195 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+20 -192) ➖ `src/Android/Resources/drawable-hdpi/card.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/cog.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/id.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/lock.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/login.png` (+0 -0) 📝 `src/Android/Resources/drawable-hdpi/logo_legacy.png` (+0 -0) 📝 `src/Android/Resources/drawable-hdpi/logo_white_legacy.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/pencil.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/plus.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/refresh.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/refresh_sm.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/search.png` (+0 -0) ➖ `src/Android/Resources/drawable-hdpi/shield.png` (+0 -0) ➕ `src/Android/Resources/drawable-v23/splash_screen.xml` (+15 -0) ➕ `src/Android/Resources/drawable-v23/splash_screen_dark.xml` (+15 -0) ➖ `src/Android/Resources/drawable-xhdpi/card.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/cog.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/id.png` (+0 -0) ➖ `src/Android/Resources/drawable-xhdpi/lock.png` (+0 -0) _...and 68 more files_ </details> ### 📄 Description Replacement of bitmap icons with vector drawables. This gives us flexibility with theming as scaling & tinting becomes programmatically possible, not to mention the ease of adjustments going forward as there is no longer a need to export multiple bitmaps if/when a change is required. (This started as part of Android 11 autofill since the icons weren't as sharp as they could be within the InlinePresentation. However as I'm now waiting for an update to Xamarin's AndroidX package, I moved on and did all the icons.) ![01_splash](https://user-images.githubusercontent.com/59324545/97890074-1c2cd000-1cfb-11eb-8ef2-87fd6c298a35.png) ![02_vault](https://user-images.githubusercontent.com/59324545/97890086-1f27c080-1cfb-11eb-9b12-569a60f4c17b.png) ![03_vault_dark](https://user-images.githubusercontent.com/59324545/97890093-20f18400-1cfb-11eb-85a9-842de1b67c8a.png) ![04_tiles](https://user-images.githubusercontent.com/59324545/97890099-2222b100-1cfb-11eb-8d3e-39995710a05b.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?