github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1124] [MERGED] Additional support for system theme setting #2759

New Issue
Closed
opened 2025-11-26 23:23:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1124
Author: @mpbw2
Created: 10/20/2020
Status: ✅ Merged
Merged: 10/20/2020
Merged by: @mpbw2

Base: master ← Head: launch-darklight

📝 Commits (4)

  • 964df9d first pass with iOS 13+ support
  • 118a771 tweaks for ios pre-13
  • 5d14bcc Added Android support for dark/light splash & detection with default theme
  • 272e13f update cipher cell text color on system theme change (android)

📊 Changes

19 files changed (+133 additions, -27 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -3)
📝 src/Android/MainActivity.cs (+14 -3)
📝 src/Android/Properties/AndroidManifest.xml (+1 -1)
📝 src/Android/Renderers/CipherViewCellRenderer.cs (+7 -3)
➕ src/Android/Resources/values-night/styles.xml (+8 -0)
➖ src/Android/Resources/values-v21/styles.xml (+0 -11)
📝 src/Android/Resources/values/styles.xml (+6 -0)
📝 src/Android/Services/DeviceActionService.cs (+11 -0)
📝 src/App/App.csproj (+1 -1)
📝 src/iOS/Info.plist (+2 -0)
📝 src/iOS/LaunchScreen.storyboard (+4 -5)
➕ src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/Contents.json (+68 -0)
➕ src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo.png (+0 -0)
➕ src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo@2x.png (+0 -0)
➕ src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo@3x.png (+0 -0)
➕ src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo_white.png (+0 -0)
➕ src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo_white@2x.png (+0 -0)
➕ src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo_white@3x.png (+0 -0)
📝 src/iOS/iOS.csproj (+10 -0)

📄 Description

  • Splash screen now respects system dark/light setting (Android & iOS)
  • Default app theme respects system dark light setting (Android only, already worked in iOS)
  • On the fly switching between dark/light when using app's Default theme (Android only for now, this was a happy accident and will require a Forms update for iOS, which we're doing but not in this light-weight PR)
  • Updated biometric lib to fix freeze on login screen when theme-switching while bio-prompt is showing (Android only)

ios_launch_dark
ios_launch
android_launch_dark
android_launch

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1124 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/20/2020 **Status:** ✅ Merged **Merged:** 10/20/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `launch-darklight` --- ### 📝 Commits (4) - [`964df9d`](https://github.com/bitwarden/android/commit/964df9d388c31eaa7eba946e7d4e088fdf701003) first pass with iOS 13+ support - [`118a771`](https://github.com/bitwarden/android/commit/118a771b8247b0e03f2ad141e1ce1df052c77e47) tweaks for ios pre-13 - [`5d14bcc`](https://github.com/bitwarden/android/commit/5d14bcca43af4b2582ce3116d63b2d5fa8c1d508) Added Android support for dark/light splash & detection with default theme - [`272e13f`](https://github.com/bitwarden/android/commit/272e13fb45764ca6794b87c5106412b78bfaa008) update cipher cell text color on system theme change (android) ### 📊 Changes **19 files changed** (+133 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -3) 📝 `src/Android/MainActivity.cs` (+14 -3) 📝 `src/Android/Properties/AndroidManifest.xml` (+1 -1) 📝 `src/Android/Renderers/CipherViewCellRenderer.cs` (+7 -3) ➕ `src/Android/Resources/values-night/styles.xml` (+8 -0) ➖ `src/Android/Resources/values-v21/styles.xml` (+0 -11) 📝 `src/Android/Resources/values/styles.xml` (+6 -0) 📝 `src/Android/Services/DeviceActionService.cs` (+11 -0) 📝 `src/App/App.csproj` (+1 -1) 📝 `src/iOS/Info.plist` (+2 -0) 📝 `src/iOS/LaunchScreen.storyboard` (+4 -5) ➕ `src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/Contents.json` (+68 -0) ➕ `src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo.png` (+0 -0) ➕ `src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo@2x.png` (+0 -0) ➕ `src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo@3x.png` (+0 -0) ➕ `src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo_white.png` (+0 -0) ➕ `src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo_white@2x.png` (+0 -0) ➕ `src/iOS/Resources/Assets.xcassets/LaunchScreen.imageset/logo_white@3x.png` (+0 -0) 📝 `src/iOS/iOS.csproj` (+10 -0) </details> ### 📄 Description - Splash screen now respects system dark/light setting (Android & iOS) - Default app theme respects system dark light setting (Android only, already worked in iOS) - On the fly switching between dark/light when using app's Default theme (Android only for now, this was a happy accident and will require a Forms update for iOS, which we're doing but not in this light-weight PR) - Updated biometric lib to fix freeze on login screen when theme-switching while bio-prompt is showing (Android only) ![ios_launch_dark](https://user-images.githubusercontent.com/59324545/96619358-1505cb00-12d4-11eb-8148-0bcd8f180ac3.png) ![ios_launch](https://user-images.githubusercontent.com/59324545/96619366-17682500-12d4-11eb-928b-7bfd10699444.png) ![android_launch_dark](https://user-images.githubusercontent.com/59324545/96619380-19ca7f00-12d4-11eb-9fe4-37eaff35d38e.png) ![android_launch](https://user-images.githubusercontent.com/59324545/96619384-1afbac00-12d4-11eb-9b41-50d6af368c20.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2759
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?