github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1117] [MERGED] fix for stuck extension sheets when dismissed by swipe #2755

New Issue
Closed
opened 2025-11-26 23:23:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1117
Author: @mpbw2
Created: 10/14/2020
Status: ✅ Merged
Merged: 10/15/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-iosmodaldismiss

📝 Commits (2)

  • a425ca5 fix for stuck extension sheets when dismissed by swipe
  • 3d4afeb simplify dismiss action assignments

📊 Changes

17 files changed (+131 additions, -8 deletions)

View changed files

📝 src/iOS.Autofill/CredentialProviderViewController.cs (+9 -0)
📝 src/iOS.Autofill/LockPasswordViewController.cs (+1 -0)
📝 src/iOS.Autofill/LoginAddViewController.cs (+11 -1)
📝 src/iOS.Autofill/LoginListViewController.cs (+12 -1)
📝 src/iOS.Autofill/LoginSearchViewController.cs (+10 -1)
📝 src/iOS.Autofill/PasswordGeneratorViewController.cs (+8 -1)
📝 src/iOS.Autofill/SetupViewController.cs (+8 -1)
📝 src/iOS.Core/Controllers/ExtendedUITableViewController.cs (+2 -0)
📝 src/iOS.Core/Controllers/ExtendedUIViewController.cs (+2 -0)
➕ src/iOS.Core/Views/CustomPresentationControllerDelegate.cs (+22 -0)
📝 src/iOS.Core/iOS.Core.csproj (+1 -0)
📝 src/iOS.Extension/LoadingViewController.cs (+9 -0)
📝 src/iOS.Extension/LockPasswordViewController.cs (+1 -0)
📝 src/iOS.Extension/LoginAddViewController.cs (+11 -1)
📝 src/iOS.Extension/LoginListViewController.cs (+10 -1)
📝 src/iOS.Extension/PasswordGeneratorViewController.cs (+8 -1)
📝 src/iOS.Extension/SetupViewController.cs (+6 -0)

📄 Description

On iOS 13+ the extension modals are displayed as sheets which enables the user to swipe them away as a method of cancelation. We have varying levels of logic attached to our cancel buttons that was not firing when the user swiped the sheet(s) away, resulting in an un-dismiss-able sheet that requires the app that triggered it to be killed. This PR attaches a delegate to each view controller to capture a dismiss-by-swipe event and fire off the same code used by the cancel buttons. Viola, no more frozen treats! According to Apple this callback only fires on dismiss-by-swipe, so using the cancel button won't result in code being executed twice.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1117 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/14/2020 **Status:** ✅ Merged **Merged:** 10/15/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-iosmodaldismiss` --- ### 📝 Commits (2) - [`a425ca5`](https://github.com/bitwarden/android/commit/a425ca52a8d6f5a4a432ff0f27c188c176fc68f3) fix for stuck extension sheets when dismissed by swipe - [`3d4afeb`](https://github.com/bitwarden/android/commit/3d4afebe4f32371b624c5715028030276d71ade5) simplify dismiss action assignments ### 📊 Changes **17 files changed** (+131 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+9 -0) 📝 `src/iOS.Autofill/LockPasswordViewController.cs` (+1 -0) 📝 `src/iOS.Autofill/LoginAddViewController.cs` (+11 -1) 📝 `src/iOS.Autofill/LoginListViewController.cs` (+12 -1) 📝 `src/iOS.Autofill/LoginSearchViewController.cs` (+10 -1) 📝 `src/iOS.Autofill/PasswordGeneratorViewController.cs` (+8 -1) 📝 `src/iOS.Autofill/SetupViewController.cs` (+8 -1) 📝 `src/iOS.Core/Controllers/ExtendedUITableViewController.cs` (+2 -0) 📝 `src/iOS.Core/Controllers/ExtendedUIViewController.cs` (+2 -0) ➕ `src/iOS.Core/Views/CustomPresentationControllerDelegate.cs` (+22 -0) 📝 `src/iOS.Core/iOS.Core.csproj` (+1 -0) 📝 `src/iOS.Extension/LoadingViewController.cs` (+9 -0) 📝 `src/iOS.Extension/LockPasswordViewController.cs` (+1 -0) 📝 `src/iOS.Extension/LoginAddViewController.cs` (+11 -1) 📝 `src/iOS.Extension/LoginListViewController.cs` (+10 -1) 📝 `src/iOS.Extension/PasswordGeneratorViewController.cs` (+8 -1) 📝 `src/iOS.Extension/SetupViewController.cs` (+6 -0) </details> ### 📄 Description On iOS 13+ the extension modals are displayed as sheets which enables the user to swipe them away as a method of cancelation. We have varying levels of logic attached to our cancel buttons that was not firing when the user swiped the sheet(s) away, resulting in an un-dismiss-able sheet that requires the app that triggered it to be killed. This PR attaches a delegate to each view controller to capture a dismiss-by-swipe event and fire off the same code used by the cancel buttons. Viola, no more frozen treats! According to Apple this callback only fires on dismiss-by-swipe, so using the cancel button won't result in code being executed twice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?