github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1112] [MERGED] clear cipher cache when replacing ios autofill identities #2753

New Issue
Closed
opened 2025-11-26 23:23:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1112
Author: @mpbw2
Created: 10/8/2020
Status: ✅ Merged
Merged: 10/13/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-ios-autofillrefresh

📝 Commits (5)

  • 4da4956 clear cipher cache when replacing ios autofill identities
  • e0f5e23 changed to be service-centric
  • 40d75f0 support for multiple cache keys
  • 08fc2f4 async suffix
  • 35d98b2 added cache keys for android

📊 Changes

11 files changed (+66 additions, -39 deletions)

View changed files

📝 src/Android/MainApplication.cs (+2 -1)
📝 src/App/App.xaml.cs (+0 -16)
📝 src/App/Services/MobileStorageService.cs (+2 -0)
📝 src/Core/Abstractions/ICipherService.cs (+1 -1)
📝 src/Core/Constants.cs (+14 -0)
📝 src/Core/Services/CipherService.cs (+37 -15)
📝 src/Core/Services/VaultTimeoutService.cs (+1 -1)
📝 src/Core/Utilities/ServiceContainer.cs (+3 -2)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+2 -1)
📝 src/iOS.Extension/LoadingViewController.cs (+2 -1)
📝 src/iOS/AppDelegate.cs (+2 -1)

📄 Description

Cipher changes from the web vault would fail to display in the iOS autofill login list even though the changes were properly displayed in the app. LoginListViewController was correctly calling ASHelpers.ReplaceAllIdentities() after the cipher changes were sync'ed to the app, but the cipherService cache in the extension was out of sync with the cache in the app. Added a generic way to inform other processes that they need to update their cache, so db modifications in one process will be available in the others.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1112 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/8/2020 **Status:** ✅ Merged **Merged:** 10/13/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-ios-autofillrefresh` --- ### 📝 Commits (5) - [`4da4956`](https://github.com/bitwarden/android/commit/4da49566d727e214c9bccab1f42529d6d534d6c1) clear cipher cache when replacing ios autofill identities - [`e0f5e23`](https://github.com/bitwarden/android/commit/e0f5e23acba916a75a4ad167c3782dc065f5d277) changed to be service-centric - [`40d75f0`](https://github.com/bitwarden/android/commit/40d75f0bdbc366651af418748e5061de34b9c195) support for multiple cache keys - [`08fc2f4`](https://github.com/bitwarden/android/commit/08fc2f415b223a56e58cce984bc8c0079755a0d7) async suffix - [`35d98b2`](https://github.com/bitwarden/android/commit/35d98b24bc124df78ebd6a5c5df215a0dd228a79) added cache keys for android ### 📊 Changes **11 files changed** (+66 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainApplication.cs` (+2 -1) 📝 `src/App/App.xaml.cs` (+0 -16) 📝 `src/App/Services/MobileStorageService.cs` (+2 -0) 📝 `src/Core/Abstractions/ICipherService.cs` (+1 -1) 📝 `src/Core/Constants.cs` (+14 -0) 📝 `src/Core/Services/CipherService.cs` (+37 -15) 📝 `src/Core/Services/VaultTimeoutService.cs` (+1 -1) 📝 `src/Core/Utilities/ServiceContainer.cs` (+3 -2) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+2 -1) 📝 `src/iOS.Extension/LoadingViewController.cs` (+2 -1) 📝 `src/iOS/AppDelegate.cs` (+2 -1) </details> ### 📄 Description Cipher changes from the web vault would fail to display in the iOS autofill login list even though the changes were properly displayed in the app. `LoginListViewController` was correctly calling `ASHelpers.ReplaceAllIdentities()` after the cipher changes were sync'ed to the app, but the cipherService cache in the extension was out of sync with the cache in the app. Added a generic way to inform other processes that they need to update their cache, so db modifications in one process will be available in the others. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2753
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?