github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1100] [MERGED] re-select support for android tabbed page buttons #2746

New Issue
Closed
opened 2025-11-26 23:23:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:32 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1100
Author: @mpbw2
Created: 10/1/2020
Status: ✅ Merged
Merged: 10/1/2020
Merged by: @mpbw2

Base: master ← Head: android-bottomnav-reselect

📝 Commits (3)

  • e752985 re-select support for android tabbed page buttons
  • beceed2 applied Sane Person Technology (tm) to index check
  • 6ec1920 remove extra line

📊 Changes

2 files changed (+61 additions, -0 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -0)
➕ src/Android/Renderers/CustomTabbedRenderer.cs (+60 -0)

📄 Description

Added support for tab button re-selection in Android to match behavior from iOS, enabling the user to return to the vault root GroupingsPage from within a Type page (Login, Card, etc.) simply by tapping My Vault again. Since we're using bottom-nav a little extra song and dance was required to get ahold of the view and set the listener.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1100 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 10/1/2020 **Status:** ✅ Merged **Merged:** 10/1/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `android-bottomnav-reselect` --- ### 📝 Commits (3) - [`e752985`](https://github.com/bitwarden/android/commit/e7529857b0a5a7769f14410508eb998fce3b2c5e) re-select support for android tabbed page buttons - [`beceed2`](https://github.com/bitwarden/android/commit/beceed28b7f54f495169066ed496e346c21f47fb) applied Sane Person Technology (tm) to index check - [`6ec1920`](https://github.com/bitwarden/android/commit/6ec19206c60d4a3fa92339acd27dcbde05e7e33d) remove extra line ### 📊 Changes **2 files changed** (+61 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -0) ➕ `src/Android/Renderers/CustomTabbedRenderer.cs` (+60 -0) </details> ### 📄 Description Added support for tab button re-selection in Android to match behavior from iOS, enabling the user to return to the vault root `GroupingsPage` from within a Type page (Login, Card, etc.) simply by tapping `My Vault` again. Since we're using bottom-nav a little extra song and dance was required to get ahold of the view and set the listener. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:32 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?