github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 22:25:22 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1096] [MERGED] Remap pt to pt-BR instead of pt-PT and handle valid mapping of pt to pt-BR initially #2743

New Issue
Closed
opened 2025-11-26 23:23:29 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:29 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1096
Author: @cscharf
Created: 9/28/2020
Status: ✅ Merged
Merged: 9/29/2020
Merged by: @cscharf

Base: master ← Head: fix/979-pt-BR-to-pt-mapping-for-ios

📝 Commits (3)

  • 42a09e1 Rename pt-BR to pt, mapping for crowdin
  • 404c578 Map localized pt to pt-BR
  • e65f660 Revert "Rename pt-BR to pt, mapping for crowdin"

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/iOS.Core/Services/LocalizeService.cs (+4 -1)

📄 Description

Should fix and close #979.

Overview

In iOS, the mapping for Portuguese (Brazil) (pt-BR) is actually mapped to pt directly and therefore can't find pt-BR from our localization files. Since iOS considers this the default for Portuguese we need to fix the localization mapping to match the base Portuguese language 2-letter code to the locale version for Brazil. This should in theory also keep those in Portugal or who have the language set to Portuguese (Portugal) (pt-PT) seeing the correct localization of the language.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1096 **Author:** [@cscharf](https://github.com/cscharf) **Created:** 9/28/2020 **Status:** ✅ Merged **Merged:** 9/29/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `fix/979-pt-BR-to-pt-mapping-for-ios` --- ### 📝 Commits (3) - [`42a09e1`](https://github.com/bitwarden/android/commit/42a09e14b74e310d1b4c9ca8d7372fd70b5678d4) Rename pt-BR to pt, mapping for crowdin - [`404c578`](https://github.com/bitwarden/android/commit/404c57843f4a6938656c462242503be83ff70985) Map localized pt to pt-BR - [`e65f660`](https://github.com/bitwarden/android/commit/e65f6606528283ea6fb322e1234f49e8e0571cdc) Revert "Rename pt-BR to pt, mapping for crowdin" ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Services/LocalizeService.cs` (+4 -1) </details> ### 📄 Description _Should_ fix and close #979. ## Overview In iOS, the mapping for Portuguese (Brazil) (`pt-BR`) is actually mapped to `pt` directly and therefore can't find `pt-BR` from our localization files. Since iOS considers this the default for Portuguese we need to fix the localization mapping to match the base Portuguese language 2-letter code to the locale version for Brazil. This _should_ in theory also keep those in Portugal or who have the language set to Portuguese (Portugal) (`pt-PT`) seeing the correct localization of the language. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:29 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2743
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?