github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 15:31:34 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1095] [MERGED] fix issue with search bar color on iOS #2742

New Issue
Closed
opened 2025-11-26 23:23:29 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:29 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1095
Author: @mpbw2
Created: 9/28/2020
Status: ✅ Merged
Merged: 9/28/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-searchbartext

📝 Commits (1)

  • 1059499 fix issue with search bar color on iOS

📊 Changes

1 file changed (+2 additions, -4 deletions)

View changed files

📝 src/App/Controls/ExtendedSearchBar.cs (+2 -4)

📄 Description

Search bar text color was not taking app theme into account (only system theme) so a light system with dark app theme resulted in dark text on a dark background. By using themehelper here we take both the app and system theme into account.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1095 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 9/28/2020 **Status:** ✅ Merged **Merged:** 9/28/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-searchbartext` --- ### 📝 Commits (1) - [`1059499`](https://github.com/bitwarden/android/commit/1059499b6bda801f5af19300db168c165fce4959) fix issue with search bar color on iOS ### 📊 Changes **1 file changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/ExtendedSearchBar.cs` (+2 -4) </details> ### 📄 Description Search bar text color was not taking app theme into account (only system theme) so a light system with dark app theme resulted in dark text on a dark background. By using themehelper here we take both the app and system theme into account. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:29 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2742
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?