github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 10:04:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1093] [MERGED] biometric integrity check in iOS extensions #2740

New Issue
Closed
opened 2025-11-26 23:23:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1093
Author: @mpbw2
Created: 9/25/2020
Status: ✅ Merged
Merged: 9/26/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-ios-biointegritycheck

📝 Commits (1)

  • 8ef1da0 biometric integrity check in iOS extensions

📊 Changes

4 files changed (+59 additions, -16 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPage.xaml (+1 -1)
📝 src/App/Pages/Accounts/LockPageViewModel.cs (+15 -2)
📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+33 -13)
📝 src/iOS.Core/Utilities/ThemeHelpers.cs (+10 -0)

📄 Description

  • Added check for biometric integrity when unlocking vault within iOS extensions
  • Removed Unlock with [touchId/faceId/biometric] button and added alert text to extension if integrity check fails
  • Also removed same bio unlock button from unlock screen in app if integrity check fails, for consistency across platforms
  • Added check for crypto key in iOS extension to verify if bio unlock is possible (for SSO login)

01
02
03
04
05
06

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1093 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 9/25/2020 **Status:** ✅ Merged **Merged:** 9/26/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-ios-biointegritycheck` --- ### 📝 Commits (1) - [`8ef1da0`](https://github.com/bitwarden/android/commit/8ef1da0688a8b51d6df81f84029ee3cbc8a7bbdc) biometric integrity check in iOS extensions ### 📊 Changes **4 files changed** (+59 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPage.xaml` (+1 -1) 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+15 -2) 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+33 -13) 📝 `src/iOS.Core/Utilities/ThemeHelpers.cs` (+10 -0) </details> ### 📄 Description - Added check for biometric integrity when unlocking vault within iOS extensions - Removed `Unlock with [touchId/faceId/biometric]` button and added alert text to extension if integrity check fails - Also removed same bio unlock button from unlock screen in app if integrity check fails, for consistency across platforms - Added check for crypto key in iOS extension to verify if bio unlock is possible (for SSO login) ![01](https://user-images.githubusercontent.com/59324545/94313097-1994c900-ff4c-11ea-90f5-2a729739c331.png) ![02](https://user-images.githubusercontent.com/59324545/94313102-1c8fb980-ff4c-11ea-95e2-8d06de18c03a.png) ![03](https://user-images.githubusercontent.com/59324545/94313113-1f8aaa00-ff4c-11ea-8af4-b5817a53c85e.png) ![04](https://user-images.githubusercontent.com/59324545/94313116-21546d80-ff4c-11ea-92cd-4abc9ebcc934.png) ![05](https://user-images.githubusercontent.com/59324545/94313121-23b6c780-ff4c-11ea-9abf-aa6cec7dcf3d.png) ![06](https://user-images.githubusercontent.com/59324545/94313125-25808b00-ff4c-11ea-8acf-589a23cbf84d.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2740
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?