github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 20:24:33 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1086] [MERGED] fix for sso login when bio unlock already enabled #2738

New Issue
Closed
opened 2025-11-26 23:23:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1086
Author: @mpbw2
Created: 9/22/2020
Status: ✅ Merged
Merged: 9/23/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-ssobiounlock

📝 Commits (1)

  • 4f1f088 fix for sso login when bio unlock already enabled

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+1 -1)
📝 src/Core/Services/CryptoService.cs (+1 -1)

📄 Description

Fix for missing key issue when logging in with SSO with biometric unlock already enabled from previous login.

LockPageViewModel: Added check for existence of key before allowing biometric unlock. This will force password unlock when logging in with SSO as a key has not yet been established.
CryptoService: Null check key before attempting Base64 conversion to prevent NPE when logging in with SSO if biometric unlock is already enabled

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1086 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 9/22/2020 **Status:** ✅ Merged **Merged:** 9/23/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-ssobiounlock` --- ### 📝 Commits (1) - [`4f1f088`](https://github.com/bitwarden/android/commit/4f1f0880d487aa793692c4a48c7d4ededdafdbbc) fix for sso login when bio unlock already enabled ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+1 -1) 📝 `src/Core/Services/CryptoService.cs` (+1 -1) </details> ### 📄 Description Fix for missing key issue when logging in with SSO with biometric unlock already enabled from previous login. `LockPageViewModel`: Added check for existence of key before allowing biometric unlock. This will force password unlock when logging in with SSO as a key has not yet been established. `CryptoService`: Null check key before attempting Base64 conversion to prevent NPE when logging in with SSO if biometric unlock is already enabled --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2738
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?