github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1047] [MERGED] Added SSO flows and functionality #2719

New Issue
Closed
opened 2025-11-26 23:23:10 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:23:10 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1047
Author: @mpbw2
Created: 8/22/2020
Status: ✅ Merged
Merged: 9/3/2020
Merged by: @mpbw2

Base: master ← Head: feature/sso

📝 Commits (10+)

  • 4709ec9 SSO login flow for pre-existing user and no 2FA
  • 74f996a 2FA progress
  • 92e9178 2FA support
  • 1e2b963 Added SSO flows and functionality
  • e70adbe Handle webauthenticator cancellation gracefully
  • 50d5cb5 updates & bugfixes
  • c777208 Added state validation to web auth response handling
  • 8ffabc0 SSO auth, account registration, and environment settings support for iOS extensions
  • 0b781db Added SSO prevalidation to auth process
  • 056fa5d prevalidation now hitting identity service base url

📊 Changes

46 files changed (+2892 additions, -2596 deletions)

View changed files

📝 src/Android/Android.csproj (+2 -1)
📝 src/Android/MainActivity.cs (+1 -0)
➕ src/Android/WebAuthCallbackActivity.cs (+11 -0)
📝 src/App/App.csproj (+9 -1)
📝 src/App/Models/AppOptions.cs (+23 -0)
📝 src/App/Pages/Accounts/EnvironmentPage.xaml.cs (+18 -3)
📝 src/App/Pages/Accounts/EnvironmentPageViewModel.cs (+4 -4)
📝 src/App/Pages/Accounts/HomePage.xaml (+7 -1)
📝 src/App/Pages/Accounts/HomePage.xaml.cs (+51 -4)
📝 src/App/Pages/Accounts/HomePageViewModel.cs (+8 -1)
📝 src/App/Pages/Accounts/LockPage.xaml.cs (+4 -17)
📝 src/App/Pages/Accounts/LockPageViewModel.cs (+26 -8)
📝 src/App/Pages/Accounts/LoginPage.xaml.cs (+8 -21)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+2 -2)
➕ src/App/Pages/Accounts/LoginSsoPage.xaml (+42 -0)
➕ src/App/Pages/Accounts/LoginSsoPage.xaml.cs (+114 -0)
➕ src/App/Pages/Accounts/LoginSsoPageViewModel.cs (+218 -0)
📝 src/App/Pages/Accounts/RegisterPage.xaml.cs (+15 -8)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+1 -0)
➕ src/App/Pages/Accounts/SetPasswordPage.xaml (+146 -0)

...and 26 more files

📄 Description

SSO login support with 2FA & password creation/validation. Makes use of WebAuthenticator from the Xamarin Essentials kit to manage external browser auth and callbacks.

I'll expand upon this further on Monday, but wanted to get the code in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1047 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 8/22/2020 **Status:** ✅ Merged **Merged:** 9/3/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature/sso` --- ### 📝 Commits (10+) - [`4709ec9`](https://github.com/bitwarden/android/commit/4709ec9f662c9bbc8930eefaad1b8837a27593e4) SSO login flow for pre-existing user and no 2FA - [`74f996a`](https://github.com/bitwarden/android/commit/74f996a7dd0cdaacc0b43b2a2186ce8602962a37) 2FA progress - [`92e9178`](https://github.com/bitwarden/android/commit/92e917888abf7139468be98d02fea3858a704c4d) 2FA support - [`1e2b963`](https://github.com/bitwarden/android/commit/1e2b9637267f2443adac95201203904ee8ca5fa4) Added SSO flows and functionality - [`e70adbe`](https://github.com/bitwarden/android/commit/e70adbe21ad5f64514ff1fec7c3ca6bb831d73b9) Handle webauthenticator cancellation gracefully - [`50d5cb5`](https://github.com/bitwarden/android/commit/50d5cb5ab0d138bed360575c57f73ee62c50ee69) updates & bugfixes - [`c777208`](https://github.com/bitwarden/android/commit/c777208601553ea241d40fb63ad50d60d7d50d41) Added state validation to web auth response handling - [`8ffabc0`](https://github.com/bitwarden/android/commit/8ffabc00755aa055077dffc0e425918421f2bf5e) SSO auth, account registration, and environment settings support for iOS extensions - [`0b781db`](https://github.com/bitwarden/android/commit/0b781dbacf5ee5312bfbb8dca94c848a851f3507) Added SSO prevalidation to auth process - [`056fa5d`](https://github.com/bitwarden/android/commit/056fa5d947e949c5a8b49f326abe6630ccb73c2e) prevalidation now hitting identity service base url ### 📊 Changes **46 files changed** (+2892 additions, -2596 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+2 -1) 📝 `src/Android/MainActivity.cs` (+1 -0) ➕ `src/Android/WebAuthCallbackActivity.cs` (+11 -0) 📝 `src/App/App.csproj` (+9 -1) 📝 `src/App/Models/AppOptions.cs` (+23 -0) 📝 `src/App/Pages/Accounts/EnvironmentPage.xaml.cs` (+18 -3) 📝 `src/App/Pages/Accounts/EnvironmentPageViewModel.cs` (+4 -4) 📝 `src/App/Pages/Accounts/HomePage.xaml` (+7 -1) 📝 `src/App/Pages/Accounts/HomePage.xaml.cs` (+51 -4) 📝 `src/App/Pages/Accounts/HomePageViewModel.cs` (+8 -1) 📝 `src/App/Pages/Accounts/LockPage.xaml.cs` (+4 -17) 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+26 -8) 📝 `src/App/Pages/Accounts/LoginPage.xaml.cs` (+8 -21) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+2 -2) ➕ `src/App/Pages/Accounts/LoginSsoPage.xaml` (+42 -0) ➕ `src/App/Pages/Accounts/LoginSsoPage.xaml.cs` (+114 -0) ➕ `src/App/Pages/Accounts/LoginSsoPageViewModel.cs` (+218 -0) 📝 `src/App/Pages/Accounts/RegisterPage.xaml.cs` (+15 -8) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+1 -0) ➕ `src/App/Pages/Accounts/SetPasswordPage.xaml` (+146 -0) _...and 26 more files_ </details> ### 📄 Description SSO login support with 2FA & password creation/validation. Makes use of `WebAuthenticator` from the Xamarin Essentials kit to manage external browser auth and callbacks. I'll expand upon this further on Monday, but wanted to get the code in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:10 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2719
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?