[PR #1012] [MERGED] Modified listing of website from Hostname to Host #2708

Closed
opened 2025-11-26 23:23:00 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1012
Author: @MattTheDev
Created: 7/14/2020
Status: Merged
Merged: 7/14/2020
Merged by: @MattTheDev

Base: masterHead: display-uri-port


📝 Commits (2)

  • d40ce88 Modified listing of website from Hostname to Host
  • ec0bd76 Removed last _hostname artifact.

📊 Changes

2 files changed (+9 additions, -9 deletions)

View changed files

📝 src/App/Pages/Vault/ViewPage.xaml (+1 -1)
📝 src/Core/Models/View/LoginUriView.cs (+8 -8)

📄 Description

Objective

Modify listing of URI to include port where applicable. Aligns with changes in jslib.

Code Changes

src/Core/Models/View/LoginUriView.cs View model changes. Hostname was no longer being used with this change, so replace Hostname with Host.

src/App/Pages/Vault/ViewPage.xaml Presentation modification. Point to new property.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1012 **Author:** [@MattTheDev](https://github.com/MattTheDev) **Created:** 7/14/2020 **Status:** ✅ Merged **Merged:** 7/14/2020 **Merged by:** [@MattTheDev](https://github.com/MattTheDev) **Base:** `master` ← **Head:** `display-uri-port` --- ### 📝 Commits (2) - [`d40ce88`](https://github.com/bitwarden/android/commit/d40ce881ed3054ac4fab7cc4af5bcac519250bf5) Modified listing of website from Hostname to Host - [`ec0bd76`](https://github.com/bitwarden/android/commit/ec0bd76aadd50753cfb127fd06ea7b2023997347) Removed last _hostname artifact. ### 📊 Changes **2 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/ViewPage.xaml` (+1 -1) 📝 `src/Core/Models/View/LoginUriView.cs` (+8 -8) </details> ### 📄 Description ## Objective Modify listing of URI to include port where applicable. Aligns with changes in jslib. ## Code Changes **src/Core/Models/View/LoginUriView.cs** View model changes. Hostname was no longer being used with this change, so replace Hostname with Host. **src/App/Pages/Vault/ViewPage.xaml** Presentation modification. Point to new property. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:23:00 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2708