github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1010] [CLOSED] Forcing autofill refresh on sync/modification of stored cred #2706

New Issue
Closed
opened 2025-11-26 23:22:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:58 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1010
Author: @MattTheDev
Created: 7/13/2020
Status: ❌ Closed

Base: master ← Head: autofill-ios-failing

📝 Commits (2)

  • cf50748 Forcing autofill refresh on sync/modification of stored cred
  • a6bbc61 Formatting fix

📊 Changes

5 files changed (+14 additions, -0 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+6 -0)
📝 src/App/Abstractions/IDeviceActionService.cs (+1 -0)
📝 src/App/Pages/Settings/SyncPageViewModel.cs (+1 -0)
📝 src/App/Pages/Vault/AddEditPageViewModel.cs (+1 -0)
📝 src/iOS.Core/Services/DeviceActionService.cs (+5 -0)

📄 Description

Objective

Issue #980 appears to be happening in 2 places:

  1. Changing credentials on the device, name or password, and going to the browser and attempting to auto fill.
  2. Syncing on device after credentials are changed on another device.

For some reason, the ASHelpers. ReplaceAllIdentities function is called within the stack ... but it wouldn't function 100% of the time within the existing process. Explicitly calling it after the credential change OR the sync, seems to resolve this inconsistency.

This fix will close #980.

Code Changes

src/App/Abstractions/IDeviceActionService.cs
src/Android/Services/DeviceActionService.cs
src/iOS.Core/Services/DeviceActionService.cs

Added new RefreshAutoFillAsync function. This gives the App access to the individual devices. Android is just a return statement. This is only applicable to iOS, Android seems to be unaffected.

src/App/Pages/Settings/SyncPageViewModel.cs
src/App/Pages/Vault/AddEditPageViewModel.cs

Implemented call to new function. Sync is when the sync is explicitly called. Add/Edit is on credential change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1010 **Author:** [@MattTheDev](https://github.com/MattTheDev) **Created:** 7/13/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `autofill-ios-failing` --- ### 📝 Commits (2) - [`cf50748`](https://github.com/bitwarden/android/commit/cf50748850ae0925c8bc7f84cea347526aee2ecc) Forcing autofill refresh on sync/modification of stored cred - [`a6bbc61`](https://github.com/bitwarden/android/commit/a6bbc61412a22109673bee928a9680b0fbcef72c) Formatting fix ### 📊 Changes **5 files changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+6 -0) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+1 -0) 📝 `src/App/Pages/Settings/SyncPageViewModel.cs` (+1 -0) 📝 `src/App/Pages/Vault/AddEditPageViewModel.cs` (+1 -0) 📝 `src/iOS.Core/Services/DeviceActionService.cs` (+5 -0) </details> ### 📄 Description ## Objective Issue #980 appears to be happening in 2 places: 1. Changing credentials on the device, name or password, and going to the browser and attempting to auto fill. 2. Syncing on device after credentials are changed on another device. For some reason, the ASHelpers. ReplaceAllIdentities function is called within the stack ... but it wouldn't function 100% of the time within the existing process. Explicitly calling it after the credential change OR the sync, seems to resolve this inconsistency. This fix will close #980. ## Code Changes **src/App/Abstractions/IDeviceActionService.cs** **src/Android/Services/DeviceActionService.cs** **src/iOS.Core/Services/DeviceActionService.cs** Added new RefreshAutoFillAsync function. This gives the App access to the individual devices. Android is just a return statement. This is only applicable to iOS, Android seems to be unaffected. **src/App/Pages/Settings/SyncPageViewModel.cs** **src/App/Pages/Vault/AddEditPageViewModel.cs** Implemented call to new function. Sync is when the sync is explicitly called. Add/Edit is on credential change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2706
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?