github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 20:24:33 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #965] [MERGED] Fix for accessibility overlay on Android 5 & 6 #2688

New Issue
Closed
opened 2025-11-26 23:22:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/965
Author: @mpbw2
Created: 6/8/2020
Status: ✅ Merged
Merged: 6/8/2020
Merged by: @kspearrin

Base: master ← Head: bugfix-accessibility

📝 Commits (2)

  • ea31fdc Fix for accessibility overlay on Android 5 & 6
  • 82e24ea changed to skip check outright until API 26

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+6 -1)

📄 Description

Turns out that while AccessibilityWindowInfo was added in Android 5, AccessibilityWindowInfo.Title didn't show up until Android 7. We recently added the Title check to prevent any drawing conflicts with autofill windows. Changed to just skip the check outright until Android 8 (when autofill was introduced).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/965 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/8/2020 **Status:** ✅ Merged **Merged:** 6/8/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `bugfix-accessibility` --- ### 📝 Commits (2) - [`ea31fdc`](https://github.com/bitwarden/android/commit/ea31fdc746322a0f3ac8b4fc1eadd5f3164eddb5) Fix for accessibility overlay on Android 5 & 6 - [`82e24ea`](https://github.com/bitwarden/android/commit/82e24ea0c0e7af37b24b2435940c8c5cec0bed3e) changed to skip check outright until API 26 ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+6 -1) </details> ### 📄 Description Turns out that while `AccessibilityWindowInfo` was added in Android 5, `AccessibilityWindowInfo.Title` didn't show up until Android 7. We recently added the `Title` check to prevent any drawing conflicts with autofill windows. Changed to just skip the check outright until Android 8 (when autofill was introduced). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2688
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?