github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #962] [MERGED] Tweak icons to better blend with Android and iOS #2686

New Issue
Closed
opened 2025-11-26 23:22:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:43 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/962
Author: @LaurentTreguier
Created: 6/7/2020
Status: ✅ Merged
Merged: 6/8/2020
Merged by: @mpbw2

Base: master ← Head: master

📝 Commits (2)

📊 Changes

25 files changed (+53 additions, -15 deletions)

View changed files

📝 src/Android/Resources/drawable/ic_launcher_foreground.xml (+29 -9)
📝 src/Android/Resources/drawable/icon.xml (+24 -6)
📝 src/Android/Resources/mipmap-hdpi/ic_launcher.png (+0 -0)
📝 src/Android/Resources/mipmap-hdpi/ic_launcher_round.png (+0 -0)
📝 src/Android/Resources/mipmap-mdpi/ic_launcher.png (+0 -0)
📝 src/Android/Resources/mipmap-mdpi/ic_launcher_round.png (+0 -0)
📝 src/Android/Resources/mipmap-xhdpi/ic_launcher.png (+0 -0)
📝 src/Android/Resources/mipmap-xhdpi/ic_launcher_round.png (+0 -0)
📝 src/Android/Resources/mipmap-xxhdpi/ic_launcher.png (+0 -0)
📝 src/Android/Resources/mipmap-xxhdpi/ic_launcher_round.png (+0 -0)
📝 src/Android/Resources/mipmap-xxxhdpi/ic_launcher.png (+0 -0)
📝 src/Android/Resources/mipmap-xxxhdpi/ic_launcher_round.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-1024.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-120.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-152.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-167.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-180.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-20.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-29.png (+0 -0)
📝 src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-40.png (+0 -0)

...and 5 more files

📄 Description

This PR make the icons deviate from the normal brand ones to attempt at having a more "seamless" look depending on the platform.
The Android icon has a shadow added like many Google apps have, while the iOS icon has a gradient like many Apple apps have.
Both icons have a slightly smaller shield. In Android, this makes the round icon feel just a tiny bit less cramped. On iOS, this is coupled with the shield being moved down a little to make it look more balanced.

I don't know if it would be accepted to not use the exact brand icon, but the icon is one of the first things we see on app stores, and small tweaks can go a long way.

Android icon foreground (background is the same #175DDC):

<?xml version="1.0" encoding="utf-8"?>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 600 600">
    <defs>
        <linearGradient gradientTransform="rotate(45)" id="shadow">
            <stop offset="0%" stop-color="#0000003F"/>
            <stop offset="100%" stop-color="#00000000"/>
        </linearGradient>
    </defs>
    <g transform="translate(105 85)">
        <polygon fill="url(#shadow)" points="377,13 795,431 560,865 65,370 195,445 370,270"/>
        <path fill="white" d="M376.4,12.2c-3.7-3.7-8.1-5.6-13.1-5.6H26.7c-5.1,0-9.4,1.9-13.1,5.6C9.9,15.9,8,20.2,8,25.3
	v224.4c0,16.7,3.3,33.4,9.8,49.8c6.5,16.5,14.6,31.1,24.3,43.8c9.6,12.8,21.1,25.2,34.5,37.2c13.3,12.1,25.7,22.1,37,30.1
	c11.3,8,23.1,15.5,35.4,22.6c12.3,7.1,21,11.9,26.2,14.5c5.2,2.5,9.3,4.5,12.4,5.8c2.3,1.2,4.9,1.8,7.6,1.8c2.7,0,5.3-0.6,7.6-1.8
	c3.1-1.4,7.3-3.3,12.4-5.8c5.2-2.5,13.9-7.4,26.2-14.5c12.3-7.1,24.1-14.7,35.4-22.6c11.3-8,23.6-18,37-30.1
	c13.3-12.1,24.8-24.5,34.5-37.2c9.6-12.8,17.7-27.4,24.2-43.8c6.5-16.5,9.8-33.1,9.8-49.8V25.3C382,20.2,380.1,15.9,376.4,12.2z
	 M333,251.8C333,333,195,403,195,403V54.6h138C333,54.6,333,170.6,333,251.8z"/>
    </g>
</svg>

iOS icon:

<?xml version="1.0" encoding="utf-8"?>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 600 600">
    <defs>
        <linearGradient id="gradient" gradientTransform="rotate(90)">
            <stop offset="0%" stop-color="#578DFC"/>
            <stop offset="100%" stop-color="#074DCC"/>
        </linearGradient>
    </defs>
    <rect width="600" height="600" fill="url(#gradient)"/>
    <path transform="translate(105 85)" fill="white" d="M376.4,12.2c-3.7-3.7-8.1-5.6-13.1-5.6H26.7c-5.1,0-9.4,1.9-13.1,5.6C9.9,15.9,8,20.2,8,25.3
	v224.4c0,16.7,3.3,33.4,9.8,49.8c6.5,16.5,14.6,31.1,24.3,43.8c9.6,12.8,21.1,25.2,34.5,37.2c13.3,12.1,25.7,22.1,37,30.1
	c11.3,8,23.1,15.5,35.4,22.6c12.3,7.1,21,11.9,26.2,14.5c5.2,2.5,9.3,4.5,12.4,5.8c2.3,1.2,4.9,1.8,7.6,1.8c2.7,0,5.3-0.6,7.6-1.8
	c3.1-1.4,7.3-3.3,12.4-5.8c5.2-2.5,13.9-7.4,26.2-14.5c12.3-7.1,24.1-14.7,35.4-22.6c11.3-8,23.6-18,37-30.1
	c13.3-12.1,24.8-24.5,34.5-37.2c9.6-12.8,17.7-27.4,24.2-43.8c6.5-16.5,9.8-33.1,9.8-49.8V25.3C382,20.2,380.1,15.9,376.4,12.2z
	 M333,251.8C333,333,195,403,195,403V54.6h138C333,54.6,333,170.6,333,251.8z"/>
</svg>

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/962 **Author:** [@LaurentTreguier](https://github.com/LaurentTreguier) **Created:** 6/7/2020 **Status:** ✅ Merged **Merged:** 6/8/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`242ac48`](https://github.com/bitwarden/android/commit/242ac484e256cc1d72c72e376d198393db2c3c21) Add shadow to Android icon - [`edb556a`](https://github.com/bitwarden/android/commit/edb556a8b4de42ec7ae747903a1befe7065cd671) Add gradient to iOS icon ### 📊 Changes **25 files changed** (+53 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Resources/drawable/ic_launcher_foreground.xml` (+29 -9) 📝 `src/Android/Resources/drawable/icon.xml` (+24 -6) 📝 `src/Android/Resources/mipmap-hdpi/ic_launcher.png` (+0 -0) 📝 `src/Android/Resources/mipmap-hdpi/ic_launcher_round.png` (+0 -0) 📝 `src/Android/Resources/mipmap-mdpi/ic_launcher.png` (+0 -0) 📝 `src/Android/Resources/mipmap-mdpi/ic_launcher_round.png` (+0 -0) 📝 `src/Android/Resources/mipmap-xhdpi/ic_launcher.png` (+0 -0) 📝 `src/Android/Resources/mipmap-xhdpi/ic_launcher_round.png` (+0 -0) 📝 `src/Android/Resources/mipmap-xxhdpi/ic_launcher.png` (+0 -0) 📝 `src/Android/Resources/mipmap-xxhdpi/ic_launcher_round.png` (+0 -0) 📝 `src/Android/Resources/mipmap-xxxhdpi/ic_launcher.png` (+0 -0) 📝 `src/Android/Resources/mipmap-xxxhdpi/ic_launcher_round.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-1024.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-120.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-152.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-167.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-180.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-20.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-29.png` (+0 -0) 📝 `src/iOS/Resources/Assets.xcassets/AppIcons.appiconset/Icon-40.png` (+0 -0) _...and 5 more files_ </details> ### 📄 Description This PR make the icons deviate from the normal brand ones to attempt at having a more "seamless" look depending on the platform. The Android icon has a shadow added like many Google apps have, while the iOS icon has a gradient like many Apple apps have. Both icons have a slightly smaller shield. In Android, this makes the round icon feel just a tiny bit less cramped. On iOS, this is coupled with the shield being moved down a little to make it look more balanced. I don't know if it would be accepted to not use the exact brand icon, but the icon is one of the first things we see on app stores, and small tweaks can go a long way. --- Android icon foreground (background is the same `#175DDC`): ```svg <?xml version="1.0" encoding="utf-8"?> <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 600 600"> <defs> <linearGradient gradientTransform="rotate(45)" id="shadow"> <stop offset="0%" stop-color="#0000003F"/> <stop offset="100%" stop-color="#00000000"/> </linearGradient> </defs> <g transform="translate(105 85)"> <polygon fill="url(#shadow)" points="377,13 795,431 560,865 65,370 195,445 370,270"/> <path fill="white" d="M376.4,12.2c-3.7-3.7-8.1-5.6-13.1-5.6H26.7c-5.1,0-9.4,1.9-13.1,5.6C9.9,15.9,8,20.2,8,25.3 v224.4c0,16.7,3.3,33.4,9.8,49.8c6.5,16.5,14.6,31.1,24.3,43.8c9.6,12.8,21.1,25.2,34.5,37.2c13.3,12.1,25.7,22.1,37,30.1 c11.3,8,23.1,15.5,35.4,22.6c12.3,7.1,21,11.9,26.2,14.5c5.2,2.5,9.3,4.5,12.4,5.8c2.3,1.2,4.9,1.8,7.6,1.8c2.7,0,5.3-0.6,7.6-1.8 c3.1-1.4,7.3-3.3,12.4-5.8c5.2-2.5,13.9-7.4,26.2-14.5c12.3-7.1,24.1-14.7,35.4-22.6c11.3-8,23.6-18,37-30.1 c13.3-12.1,24.8-24.5,34.5-37.2c9.6-12.8,17.7-27.4,24.2-43.8c6.5-16.5,9.8-33.1,9.8-49.8V25.3C382,20.2,380.1,15.9,376.4,12.2z M333,251.8C333,333,195,403,195,403V54.6h138C333,54.6,333,170.6,333,251.8z"/> </g> </svg> ``` iOS icon: ```svg <?xml version="1.0" encoding="utf-8"?> <svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 600 600"> <defs> <linearGradient id="gradient" gradientTransform="rotate(90)"> <stop offset="0%" stop-color="#578DFC"/> <stop offset="100%" stop-color="#074DCC"/> </linearGradient> </defs> <rect width="600" height="600" fill="url(#gradient)"/> <path transform="translate(105 85)" fill="white" d="M376.4,12.2c-3.7-3.7-8.1-5.6-13.1-5.6H26.7c-5.1,0-9.4,1.9-13.1,5.6C9.9,15.9,8,20.2,8,25.3 v224.4c0,16.7,3.3,33.4,9.8,49.8c6.5,16.5,14.6,31.1,24.3,43.8c9.6,12.8,21.1,25.2,34.5,37.2c13.3,12.1,25.7,22.1,37,30.1 c11.3,8,23.1,15.5,35.4,22.6c12.3,7.1,21,11.9,26.2,14.5c5.2,2.5,9.3,4.5,12.4,5.8c2.3,1.2,4.9,1.8,7.6,1.8c2.7,0,5.3-0.6,7.6-1.8 c3.1-1.4,7.3-3.3,12.4-5.8c5.2-2.5,13.9-7.4,26.2-14.5c12.3-7.1,24.1-14.7,35.4-22.6c11.3-8,23.6-18,37-30.1 c13.3-12.1,24.8-24.5,34.5-37.2c9.6-12.8,17.7-27.4,24.2-43.8c6.5-16.5,9.8-33.1,9.8-49.8V25.3C382,20.2,380.1,15.9,376.4,12.2z M333,251.8C333,333,195,403,195,403V54.6h138C333,54.6,333,170.6,333,251.8z"/> </svg> ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:43 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2686
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?