github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 20:24:33 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #960] [MERGED] Fix for deadlock in iOS autofill & share extensions #2685

New Issue
Closed
opened 2025-11-26 23:22:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/960
Author: @mpbw2
Created: 6/7/2020
Status: ✅ Merged
Merged: 6/7/2020
Merged by: @mpbw2

Base: master ← Head: autofill-async-fixes

📝 Commits (1)

  • 1d5672e Fix for deadlock in iOS autofill & share extensions

📊 Changes

3 files changed (+25 additions, -24 deletions)

View changed files

📝 src/iOS.Autofill/CredentialProviderViewController.cs (+16 -16)
📝 src/iOS.Autofill/SetupViewController.cs (+1 -0)
📝 src/iOS.Extension/LoadingViewController.cs (+8 -8)

📄 Description

Replaced use of GetAwaiter().GetResult() within autofill and sharing extension view controllers, fixes frozen and/or partially drawn autofill windows when setting up and using autofill.

Before:

before

After:

after

Also fixed the dark-text-on-dark-background issue for the autofill setup completion header (now matches "success" color used in share extension)

Autofill:

autofill_success

Share:

share_success

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/960 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/7/2020 **Status:** ✅ Merged **Merged:** 6/7/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `autofill-async-fixes` --- ### 📝 Commits (1) - [`1d5672e`](https://github.com/bitwarden/android/commit/1d5672e61699d97c417226257302c988c1ce0684) Fix for deadlock in iOS autofill & share extensions ### 📊 Changes **3 files changed** (+25 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+16 -16) 📝 `src/iOS.Autofill/SetupViewController.cs` (+1 -0) 📝 `src/iOS.Extension/LoadingViewController.cs` (+8 -8) </details> ### 📄 Description Replaced use of `GetAwaiter().GetResult()` within autofill and sharing extension view controllers, fixes frozen and/or partially drawn autofill windows when setting up and using autofill. Before: ![before](https://user-images.githubusercontent.com/59324545/83959899-6f841a80-a850-11ea-82f7-22233f345360.png) After: ![after](https://user-images.githubusercontent.com/59324545/83959900-76129200-a850-11ea-8a0c-732ba32f9da1.png) Also fixed the dark-text-on-dark-background issue for the autofill setup completion header (now matches "success" color used in share extension) Autofill: ![autofill_success](https://user-images.githubusercontent.com/59324545/83959950-f2a57080-a850-11ea-9007-138faf2bf986.png) Share: ![share_success](https://user-images.githubusercontent.com/59324545/83959955-fb964200-a850-11ea-968f-216878817888.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2685
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?