github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #930] [MERGED] Avoid Task.Result usage #2667

New Issue
Closed
opened 2025-11-26 23:22:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/930
Author: @cscharf
Created: 5/29/2020
Status: ✅ Merged
Merged: 5/29/2020
Merged by: @cscharf

Base: master ← Head: code-review-1

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+2 -2)

📄 Description

Avoid Task.Result usage in application in apps with the UI thread, this can cause deadlocks, await a task instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/930 **Author:** [@cscharf](https://github.com/cscharf) **Created:** 5/29/2020 **Status:** ✅ Merged **Merged:** 5/29/2020 **Merged by:** [@cscharf](https://github.com/cscharf) **Base:** `master` ← **Head:** `code-review-1` --- ### 📝 Commits (1) - [`967cefe`](https://github.com/bitwarden/android/commit/967cefe12c1740e07dc2fd90c01a92df9ddf2bcb) Avoid Task.Result usage ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+2 -2) </details> ### 📄 Description Avoid Task.Result usage in application in apps with the UI thread, this can cause deadlocks, await a task instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2667
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?