github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 03:09:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #929] [MERGED] [Auto Logout] Update lock option to be default value #2666

New Issue
Closed
opened 2025-11-26 23:22:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/929
Author: @vincentsalucci
Created: 5/29/2020
Status: ✅ Merged
Merged: 5/29/2020
Merged by: @vincentsalucci

Base: feature-auto-logout ← Head: fal-lock-default

📝 Commits (2)

  • 2dd0ac9 Initial commit - make lock action default
  • d3a7118 Removed extra whitespace

📊 Changes

3 files changed (+7 additions, -7 deletions)

View changed files

📝 src/App/App.xaml.cs (+3 -3)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+1 -1)
📝 src/Core/Services/VaultTimeoutService.cs (+3 -3)

📄 Description

Objective

Make sure that the lock option is the default value even if the setting has not been explicitly set and/or the app is updated instead of cleanly installed.

Code Changes

  • App.xaml.cs: Changed conditional logic to make lock option the default action
  • SettingsPageViewModel.cs: Added default for lock if saved action was null
  • VaultTimeoutService.cs: Changed conditional logic to make lock option the default action

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/929 **Author:** [@vincentsalucci](https://github.com/vincentsalucci) **Created:** 5/29/2020 **Status:** ✅ Merged **Merged:** 5/29/2020 **Merged by:** [@vincentsalucci](https://github.com/vincentsalucci) **Base:** `feature-auto-logout` ← **Head:** `fal-lock-default` --- ### 📝 Commits (2) - [`2dd0ac9`](https://github.com/bitwarden/android/commit/2dd0ac939500649b1eac125e235dbb388bb73cdc) Initial commit - make lock action default - [`d3a7118`](https://github.com/bitwarden/android/commit/d3a7118e4e226631c80f09261a43d684c93a8a8a) Removed extra whitespace ### 📊 Changes **3 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+3 -3) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+1 -1) 📝 `src/Core/Services/VaultTimeoutService.cs` (+3 -3) </details> ### 📄 Description ## Objective > Make sure that the `lock` option is the default value even if the setting has not been explicitly set and/or the app is updated instead of cleanly installed. ## Code Changes - **App.xaml.cs**: Changed conditional logic to make lock option the default action - **SettingsPageViewModel.cs**: Added default for `lock` if saved action was null - **VaultTimeoutService.cs**: Changed conditional logic to make lock option the default action --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2666
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?