github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #928] [MERGED] Dispose of LiteDatabase instance #2665

New Issue
Closed
opened 2025-11-26 23:22:23 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:23 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/928
Author: @kspearrin
Created: 5/28/2020
Status: ✅ Merged
Merged: 5/28/2020
Merged by: @kspearrin

Base: master ← Head: disposelitedb

📝 Commits (1)

  • 6175739 Dispost of LiteDatabase instance

📊 Changes

3 files changed (+31 additions, -4 deletions)

View changed files

📝 src/App/Services/MobileStorageService.cs (+14 -1)
📝 src/Core/Services/LiteDbStorageService.cs (+10 -3)
📝 src/Core/Utilities/ServiceContainer.cs (+7 -0)

📄 Description

LiteDB broke something in latest update. We now need to properly dispose of the database object or we get exceptions on file locking when trying to re-construct.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/928 **Author:** [@kspearrin](https://github.com/kspearrin) **Created:** 5/28/2020 **Status:** ✅ Merged **Merged:** 5/28/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `disposelitedb` --- ### 📝 Commits (1) - [`6175739`](https://github.com/bitwarden/android/commit/6175739fcb5862cc4eb728f659b5b0981c05269f) Dispost of LiteDatabase instance ### 📊 Changes **3 files changed** (+31 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Services/MobileStorageService.cs` (+14 -1) 📝 `src/Core/Services/LiteDbStorageService.cs` (+10 -3) 📝 `src/Core/Utilities/ServiceContainer.cs` (+7 -0) </details> ### 📄 Description LiteDB broke something in latest update. We now need to properly dispose of the database object or we get exceptions on file locking when trying to re-construct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:23 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?