github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #923] [MERGED] Early support for future versions of Firefox (+ some forks) #2663

New Issue
Closed
opened 2025-11-26 23:22:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:22:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/923
Author: @contribucious
Created: 5/24/2020
Status: ✅ Merged
Merged: 5/26/2020
Merged by: @mpbw2

Base: master ← Head: future-firefox--plus-some-forks--early-support

📝 Commits (2)

  • cb71b9e Early support for future versions of Firefox
  • 4c99f6f Early support for future versions of some Firefox forks

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+6 -6)

📄 Description

Observation / Deduction

The resource-id value progressively goes from url_bar_title to mozac_browser_toolbar_url_view in Firefox browsers.

In the order of their appearance, it seems to be: org.mozilla.fenix.nightly -> org.mozilla.fenix and then org.mozilla.fennec_aurora -> org.mozilla.firefox_beta.

↪️ We can therefore easily deduce that the next on the list will be org.mozilla.firefox very soon*.

* Recently tested and this is not yet the case, for information.

Therefore ...

This PR adds this new resource-id value:

  • for org.mozilla.firefox in anticipation (this is specified) and
  • for some Firefox forks* in anticipation (also specified).
* Those that use the same resource-id value as the one used by Firefox, i.e. url_bar_title.

Additional information

Ideally, a swapping of the two entries of these resource-id values will be done when the time comes; url_bar_title becoming Legacy.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/923 **Author:** [@contribucious](https://github.com/contribucious) **Created:** 5/24/2020 **Status:** ✅ Merged **Merged:** 5/26/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `future-firefox--plus-some-forks--early-support` --- ### 📝 Commits (2) - [`cb71b9e`](https://github.com/bitwarden/android/commit/cb71b9e5bf8037939c065b7c0a3a4e21fdff76b1) Early support for future versions of Firefox - [`4c99f6f`](https://github.com/bitwarden/android/commit/4c99f6faf2e7b68fb2d4b21b7183880beb908ac2) Early support for future versions of some Firefox forks ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+6 -6) </details> ### 📄 Description ## Observation / Deduction The resource-id value progressively goes from `url_bar_title` to `mozac_browser_toolbar_url_view` in Firefox browsers. In the order of their appearance, it seems to be: `org.mozilla.fenix.nightly` **->** `org.mozilla.fenix` and then `org.mozilla.fennec_aurora` **->** `org.mozilla.firefox_beta`. :arrow_right_hook: We can therefore easily deduce that the next on the list will be `org.mozilla.firefox` very soon<sup>*</sup>. ###### <sup>*</sup> Recently tested and this is not yet the case, for information. ## Therefore ... This PR adds this new resource-id value: - for `org.mozilla.firefox` _in anticipation_ (this is specified) and - for some Firefox forks<sup>*</sup> _in anticipation_ (also specified). ###### <sup>*</sup> Those that use the same resource-id value as the one used by Firefox, i.e. `url_bar_title`. ## Additional information Ideally, a swapping of the two entries of these resource-id values will be done when the time comes; `url_bar_title` becoming Legacy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:22:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#2663
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?